Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Font Library Address Outstanding Feedback from WP 6.4 review #58675

Merged
merged 8 commits into from
Feb 5, 2024
Merged

Font Library Address Outstanding Feedback from WP 6.4 review #58675

merged 8 commits into from
Feb 5, 2024

Conversation

getdave
Copy link
Contributor

@getdave getdave commented Feb 5, 2024 •
edited
Loading

What?

This PR applies any feedback that may have been missed from a review on the original Fonts proposal for WP 6.4 which happened on WordPress/wordpress-develop#5285.

Why?

Much of the review is now outdated and is largely stale. Nonetheless, this is a good opportunity to pick up on any queries that have previously been raised as it is easy to miss things from months ago.

How?

Applies any outstanding feedback where it could be identified and applied directly without further discussion.

Any further feedback should now happen on the new Core PR(s) for the Font Library.

Testing Instructions

Testing Instructions for Keyboard

Screenshots or screencast

@getdave getdave added [Type] Code Quality Issues or PRs that relate to code quality [Feature] Font Library labels Feb 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 5, 2024 •
edited
Loading

This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress.

If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged.

If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack.

Thank you! ❤️

View changed files
❔ lib/compat/wordpress-6.5/fonts/class-wp-font-collection.php
❔ lib/compat/wordpress-6.5/fonts/class-wp-font-library.php
❔ lib/compat/wordpress-6.5/fonts/class-wp-font-utils.php
❔ lib/compat/wordpress-6.5/fonts/class-wp-rest-font-collections-controller.php
❔ lib/compat/wordpress-6.5/fonts/class-wp-rest-font-faces-controller.php
❔ lib/compat/wordpress-6.5/fonts/class-wp-rest-font-families-controller.php
❔ phpunit/tests/fonts/font-library/wpRestFontFacesController.php

This was referenced Feb 5, 2024
Closed
Closed
@getdave getdave marked this pull request as ready for review February 5, 2024 16:01
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 5, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core SVN

If you're a Core Committer, use this list when committing to wordpress-develop in SVN:

Props: get_dave, grantmkin, swissspidy, mmaattiiaass, hellofromtonya.

GitHub Merge commits

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: getdave <get_dave@git.wordpress.org>
Co-authored-by: creativecoder <grantmkin@git.wordpress.org>
Co-authored-by: swissspidy <swissspidy@git.wordpress.org>
Co-authored-by: matiasbenedetto <mmaattiiaass@git.wordpress.org>
Co-authored-by: hellofromtonya <hellofromtonya@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

getdave
getdave commented Feb 5, 2024
View reviewed changes
lib/compat/wordpress-6.5/fonts/class-wp-font-collection.php
@@ -194,7 +194,7 @@ private function sanitize_and_validate_data( $data ) {
if ( empty( $data[ $property ] ) ) {
$message = sprintf(
// translators: 1: Font collection slug, 2: Missing property name.
__( 'Font collection "%1$s" has missing or empty property: "%2$s."', 'gutenberg' ),
__( 'Font collection "%1$s" has missing or empty property: "%2$s".', 'gutenberg' ),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feedback from https://wordpress.slack.com/archives/C02QB2JS7/p1707143390995019

@getdave getdave changed the title Font Library Address Outstanding Feedback Font Library Address Outstanding Feedback from WP 6.4 review Feb 5, 2024
@getdave getdave mentioned this pull request Feb 5, 2024
Closed
swissspidy
swissspidy reviewed Feb 5, 2024
View reviewed changes
lib/compat/wordpress-6.5/fonts/class-wp-font-collection.php Outdated
@@ -162,7 +162,7 @@ private function load_from_url( $url ) {

$data = json_decode( wp_remote_retrieve_body( $response ), true );
if ( empty( $data ) ) {
return new WP_Error( 'font_collection_decode_error', __( 'Error decoding the font collection data from the REST response JSON.', 'gutenberg' ) );
return new WP_Error( 'font_collection_decode_error', __( 'Error decoding the font collection data from the http response JSON.', 'gutenberg' ) );
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd assume HTTP to be capitalized here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated here: 59e6fde

creativecoder
creativecoder approved these changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@creativecoder creativecoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went through the comments on the previous Font Library Core PR, and tried to uncover all of the hidden and previously resolved comments.

To my knowledge, these changes address the outstanding feedback there.

hellofromtonya
hellofromtonya approved these changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@hellofromtonya hellofromtonya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes made LGTM.

Note: I did not cross-reference with the original PR to ensure all feedback is addressed. That said, I'm sure @getdave @creativecoder @matiasbenedetto did a great job.

@getdave getdave merged commit 0f2f287 into trunk Feb 5, 2024
59 of 60 checks passed
@getdave getdave deleted the fix/font-library-outstanding-feedback branch February 5, 2024 19:48
@github-actions github-actions bot added this to the Gutenberg 17.7 milestone Feb 5, 2024
getdave added a commit to youknowriad/wordpress-develop that referenced this pull request Feb 5, 2024
@getdave
Apply fixes from WordPress/gutenberg#58675
507f1d9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matiasbenedetto matiasbenedetto matiasbenedetto left review comments

@swissspidy swissspidy swissspidy left review comments

@hellofromtonya hellofromtonya hellofromtonya approved these changes

@creativecoder creativecoder creativecoder approved these changes

@spacedmonkey spacedmonkey Awaiting requested review from spacedmonkey spacedmonkey is a code owner

@youknowriad youknowriad Awaiting requested review from youknowriad

Assignees

@pbking pbking

@matiasbenedetto matiasbenedetto

@creativecoder creativecoder

Labels
[Feature] Font Library [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
Gutenberg 17.7
Development

Successfully merging this pull request may close these issues.
6 participants
@getdave @swissspidy @matiasbenedetto @creativecoder @hellofromtonya @pbking