FontSizePicker: Hard deprecate bottom margin #58702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirka
added
[Type] Code Quality
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core SVNCore Committers: Use this line as a base for the props when committing in SVN: GitHub Merge commitsIf you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
20 tasks
|
Size Change: -170 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
32 tasks
mirka
added
has dev note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #39358
What?
Promotes
__nextHasNoMarginBottomon FontSizePicker to the default behavior.Why?
The deprecation grace period has elapsed.
Testing Instructions
In the Storybook for FontSizePicker, turn on the margin checker tool in the toolbar. The margin-free styles should now be the default, and the
__nextHasNoMarginBottomprop should not be listed in the props table.✅ The wrapped FontSizePicker component exported from
@wordpress/block-editorfollowed the same deprecation schedule as the canonical FontSizePicker component.✅ Other usages in the Gutenberg app already are in margin-free mode.
✅ There are no internal components that use FontSizePicker under the hood.
✍️ Dev Note
See Dev Note for #58699.