Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interactivity API: Support setting a namespace using a string in data-wp-interactive #58743

Merged
merged 6 commits into from
Feb 7, 2024

Conversation

luisherranz
Copy link
Member

@luisherranz luisherranz commented Feb 6, 2024

What?

Support setting a namespace using a string in data-wp-interactive, like data-wp-intearctive="myPlugin".

Why?

Because the namespace is the main and only property supported now, so it makes sense to allow it, instead of the longer data-wp-interactive='{ "namespace": "myPlugin" }' form.

How?

By checking if the attribute value of data-wp-intearctive is a string, and if it is, using it as the namespace.


In the server, string namespaces are supported in this WP Core PR:

Be aware that here in Gutenberg this will be supported once the PR is committed to WP Core and the code is synced back to Gutenberg.


Co-authored with @sirreal.

@luisherranz luisherranz added [Type] Enhancement A suggestion for improvement. [Feature] Interactivity API API to add frontend interactivity to blocks. [Packages] Interactivity /packages/interactivity labels Feb 6, 2024
@luisherranz luisherranz self-assigned this Feb 6, 2024
Copy link

github-actions bot commented Feb 6, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core SVN

Core Committers: Use this line as a base for the props when committing in SVN:

Props luisherranz, darerodz.

GitHub Merge commits

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: luisherranz <luisherranz@git.wordpress.org>
Co-authored-by: DAreRodz <darerodz@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@luisherranz
Copy link
Member Author

I've added again the namespace restrictions because as @DAreRodz pointed out, things that contain :: could fail, like { "text": "Hi :: there!" } or "Hi :: there!".

I'll apply the same restrictions in the server directive processing.

Copy link
Contributor

@DAreRodz DAreRodz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

PS: I guess have to update the namespaces from objects to strings in core blocks, right? We can do so in a different PR, don't worry. 😄

@luisherranz
Copy link
Member Author

It's not strictly required because both are supported, but yeah, it'd be nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Interactivity API API to add frontend interactivity to blocks. [Packages] Interactivity /packages/interactivity [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants