-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interactivity API: Support setting a namespace using a string in data-wp-interactive
#58743
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core SVNCore Committers: Use this line as a base for the props when committing in SVN:
GitHub Merge commitsIf you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
I've added again the namespace restrictions because as @DAreRodz pointed out, things that contain I'll apply the same restrictions in the server directive processing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
PS: I guess have to update the namespaces from objects to strings in core blocks, right? We can do so in a different PR, don't worry. 😄
It's not strictly required because both are supported, but yeah, it'd be nice. |
What?
Support setting a namespace using a string in
data-wp-interactive
, likedata-wp-intearctive="myPlugin"
.Why?
Because the namespace is the main and only property supported now, so it makes sense to allow it, instead of the longer
data-wp-interactive='{ "namespace": "myPlugin" }'
form.How?
By checking if the attribute value of
data-wp-intearctive
is a string, and if it is, using it as the namespace.In the server, string namespaces are supported in this WP Core PR:
Be aware that here in Gutenberg this will be supported once the PR is committed to WP Core and the code is synced back to Gutenberg.
Co-authored with @sirreal.