Font Library: fix infinite loop when calling wp_get_upload_dir in a function that's used to filter font_dir

[matiasbenedetto]

What?

Fix infinite loop when calling wp_get_upload_dir in a function that's used to filter font_dir.
An alternative approach to: WordPress/wordpress-develop#6198

Why?

This avoids an infinite loop that can occur if wp_upload_dir() is called inside a 'font_dir' callback.
Fix: #58696

Testing instructions

1. Use wp_get_upload_dir() inside a function used to filter upload_dir as in the following example:

 function alter_wp_fonts_dir( $defaults ) {
	$wp_upload_dir = wp_get_upload_dir();
	$uploads_basedir = $wp_upload_dir['basedir'];
	$uploads_baseurl = $wp_upload_dir['baseurl'];

	$fonts_dir = $uploads_basedir . '/fonts';
	// Generate the URL for the fonts directory from the font dir.
	$fonts_url = str_replace( $uploads_basedir, $uploads_baseurl, $fonts_dir );

	$defaults['path'] = $fonts_dir;
	$defaults['url']  = $fonts_url;

	return $defaults;
}
add_filter( 'font_dir', 'alter_wp_fonts_dir' );

2. Upload fonts using the font library
3. Check that the fonts were successfully uploaded to the path set by the filter.
   (wp-content/uploads/fonts in the example provided).

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: matiasbenedetto <mmaattiiaass@git.wordpress.org>
Co-authored-by: costdev <costdev@git.wordpress.org>
Co-authored-by: creativecoder <grantmkin@git.wordpress.org>
Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
Co-authored-by: dd32 <dd32@git.wordpress.org>
Co-authored-by: jazzsequence <jazzs3quence@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[github-actions]

This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress.

If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged.

If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack.

Thank you! ❤️

View changed files

❔ lib/compat/wordpress-6.5/fonts/class-wp-rest-font-faces-controller.php
❔ lib/compat/wordpress-6.5/fonts/fonts.php

[creativecoder]

This works well for me, following the testing instructions to change the fonts folder to be within wp-content/uploads. I was able to install and delete fonts with font files in that directory.

---

One thing to note is that the very first font I installed, I saw an error (the same one we are tracking in #59023), but couldn't replicate it after the first time. That's not related to this change, so I don't think it should block this PR.

[youknowriad]

I just cherry-picked this PR to the update/packages-6.5-rc1 branch to get it included in the next release: b5f2b33