Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popover: add box-sizing reset style #58871

Merged
merged 4 commits into from
Feb 9, 2024
Merged

Popover: add box-sizing reset style #58871

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c97b3aa
Popover: add `box-sizing:reset`
t-hamano Feb 9, 2024
bdeb507
Update changelog
t-hamano Feb 9, 2024
64f0c07
Fix typo in CHANGELOG
t-hamano Feb 9, 2024
2c1f8de
Merge branch 'trunk' into popover/add-box-sizing-reset
t-hamano Feb 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/components/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
- `Placeholder`: Fix Global Styles typography settings bleeding into placeholder component ([#58303](https://github.com/WordPress/gutenberg/pull/58303)).
- `PaletteEdit`: Fix palette item accessibility in details view ([#58214](https://github.com/WordPress/gutenberg/pull/58214)).
- `Snackbar`: Fix the auto-dismissal timers ([#58604](https://github.com/WordPress/gutenberg/pull/58604)).
- `Popover`, Add `box-sizing` reset style ([#58871](https://github.com/WordPress/gutenberg/pull/58871)).
t-hamano marked this conversation as resolved.
Show resolved Hide resolved

### Experimental

Expand Down
1 change: 1 addition & 0 deletions packages/components/src/popover/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ $shadow-popover-border-top-only: 0 #{-$border-width} 0 0 $gray-400;
$shadow-popover-border-top-only-alternate: 0 #{-$border-width} 0 $gray-900;

.components-popover {
@include reset;
z-index: z-index(".components-popover");
will-change: transform;

Expand Down
3 changes: 1 addition & 2 deletions packages/customize-widgets/src/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@

// Include reset CSS for the customizer.
.customize-control-sidebar_block_editor,
.customize-widgets-layout__inspector,
.customize-widgets-popover {
.customize-widgets-layout__inspector {
@include reset;
}
1 change: 0 additions & 1 deletion packages/edit-post/src/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ body.js.block-editor-page {
.edit-post-text-editor,
.edit-post-sidebar,
.editor-post-publish-panel,
.components-popover,
.components-modal__frame {
@include reset;
}
Expand Down
Loading