URLPopover: Fix a problem with the layout of link settings #58906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -3 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
t-hamano
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
I will give this PR a backport label. This is because this layout problem appeared in #57608, and I think it can also be considered a regression that occurred in WP6.5. |
t-hamano
added
the
Backport to WP 6.7 Beta/RC
getdave
force-pushed
the
fix/url-popover-settings-layout
branch
from
948720a
to
66d612a
Compare
getdave
approved these changes
Feb 28, 2024
|
@getdave Thanks for the review! |
youknowriad
pushed a commit
that referenced
this pull request
Mar 4, 2024
Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: getdave <get_dave@git.wordpress.org>
|
I just cherry-picked this PR to the update/packages-6.5-rc1 branch to get it included in the next release: 8f8f533 |
youknowriad
added
Backported to WP Core
youknowriad
pushed a commit
that referenced
this pull request
Mar 4, 2024
Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: getdave <get_dave@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up #57608, #58505
What?
This PR fixes the layout collapse when opening "Link Settings" in the URLPopover component.
Why?
As far as I investigated, I think that the location rendered by
renderSettingsmay not be correct in the first place. There may have been no problems up until now, but the redesign with #57608 may have caused the layout to break down.I think it's easier to apply a consistent style if this setting is placed in parallel with
additionalControls.How?
I changed where the content is rendered when opening the link settings. The
block-editor-url-popover__rowclass should also be unnecessary.This PR only includes minimal fixes, but we should fix those issues in a follow-up. Based on the discussion made in #58505, at least the following issues should be addressed:
Testing Instructions