Block Bindings: Fix disable bindings editing when source is undefined #58961

SantosGuillamot · 2024-02-13T08:56:23Z

What?

Right now, when users bind an attribute to a source that is not registered in the editor, it doesn't lock the UI. In this pull request, I'm trying to fix that.

Additionally, I'm adding some tests to check that.

Why?

It is the expected behavior for this initial version.

How?

Adding a conditional to check that.

Testing Instructions

Tests should cover the use cases.

For manual testing:

Ensure that the existing bindings keep working as expected:

Register a new custom field however you prefer. You can use a snippet similar to this:

register_meta(
	'post',
	'text_custom_field',
	array(
		'show_in_rest' => true,
		'single'       => true,
		'type'         => 'string',
		'default'	   => 'This is the content of the text custom field',
	)
);
register_meta(
	'post',
	'url_custom_field',
	array(
		'show_in_rest' => true,
		'single'       => true,
		'type'         => 'string',
		'default'	   => 'https://wpmovies.dev/wp-content/uploads/2023/04/goncharov-poster-original-1-682x1024.jpeg',
	)
);

In a page

Test paragraph

Add a paragraph with the content connected to a custom field:

<!-- wp:paragraph {"metadata":{"bindings":{"content":{"source":"core/post-meta","args":{"key":"text_custom_field"}}}}} -->
<p>Hello</p>
<!-- /wp:paragraph -->

Add a paragraph without any bindings.
Check that the paragraph with the bindings became non-editable.
Check that the paragraph shows the content of the custom field.
Check that the normal paragraph works as expected.
Go to the frontend and check that the value of the custom field is shown there.
Change the source to a non existing one, update, and check it is non-editable.

Test heading

Repeat the paragraph test but using a heading.

Test button

Add a button with the text connected to a custom field.
Add another button with the URL connected to a custom field.
Add a button with the text and the URL connected to custom fields.

<!-- wp:buttons -->
<div class="wp-block-buttons"><!-- wp:button {"metadata":{"bindings":{"text":{"source":"core/post-meta","args":{"key":"text_custom_field"}}}}} -->
<div class="wp-block-button"><a class="wp-block-button__link wp-element-button">TEXT</a></div>
<!-- /wp:button -->

<!-- wp:button {"metadata":{"bindings":{"url":{"source":"core/post-meta","args":{"key":"url_custom_field"}}}}} -->
<div class="wp-block-button"><a class="wp-block-button__link wp-element-button" href="https://wpmovies.dev/wp-content/uploads/2023/03/3bhkrj58Vtu7enYsRolD1fZdja1-683x1024.jpg">URL</a></div>
<!-- /wp:button -->

<!-- wp:button {"metadata":{"bindings":{"text":{"source":"core/post-meta","args":{"key":"text_custom_field"}},"url":{"source":"core/post-meta","args":{"key":"url_custom_field"}}}}} -->
<div class="wp-block-button"><a class="wp-block-button__link wp-element-button" href="https://wpmovies.dev/wp-content/uploads/2023/03/3bhkrj58Vtu7enYsRolD1fZdja1-683x1024.jpg">TEXT</a></div>
<!-- /wp:button --></div>
<!-- /wp:buttons -->

Check that for the buttons with the text connected, they are not editable and they show the content of the custom field.
Check that for the buttons with the URL connected, the buttons to change the URL disappear from the UI.
Check that everything works in the frontend.

Test image

Add an image with the URL connected to a custom field.
Add an image with the alt attribute connected to a custom field.
Add an image with the title attribute connected to a custom field.
Add an image with more than one connection.

<!-- wp:heading {"level":3} -->
<h3 class="wp-block-heading">Image url and alt connected</h3>
<!-- /wp:heading -->

<!-- wp:image {"id":134,"sizeSlug":"large","linkDestination":"none","metadata":{"bindings":{"url":{"source":"core/post-meta","args":{"key":"page_url_custom_field"}},"alt":{"source":"core/post-meta","args":{"key":"page_text_custom_field"}}}}} -->
<figure class="wp-block-image size-large"><img src="https://wpmovies.dev/wp-content/uploads/2023/03/3bhkrj58Vtu7enYsRolD1fZdja1-683x1024.jpg" alt="Content of the page_text_custom_field" class="wp-image-134" title="Content of the PAGE text custom field"/></figure>
<!-- /wp:image -->

<!-- wp:heading {"level":3} -->
<h3 class="wp-block-heading">Alt connected</h3>
<!-- /wp:heading -->

<!-- wp:image {"sizeSlug":"large","linkDestination":"none","metadata":{"bindings":{"alt":{"source":"core/post-meta","args":{"key":"page_text_custom_field"}}}}} -->
<figure class="wp-block-image size-large"><img src="https://wpmovies.dev/wp-content/uploads/2023/04/q6y0Go1tsGEsmtFryDOJo3dEmqu-683x1024.jpg" alt="Content of the page_text_custom_field" title=""/></figure>
<!-- /wp:image -->

<!-- wp:heading {"level":3} -->
<h3 class="wp-block-heading">Nothing connected</h3>
<!-- /wp:heading -->

<!-- wp:image {"sizeSlug":"large","linkDestination":"none"} -->
<figure class="wp-block-image size-large"><img src="https://wpmovies.dev/wp-content/uploads/2023/04/q6y0Go1tsGEsmtFryDOJo3dEmqu-683x1024.jpg" alt=""/></figure>
<!-- /wp:image -->

For the images with the URL connected, check that the related buttons to link an image have disappeared and the image shows the URL from the custom field.
For the images with the alt/title connected, check that, in the right sidebar, they are disabled. Showing the value of the custom field instead and a message saying it is connected to custom fields.

In a template

Go to a page template, for example, and repeat the process. In this case, the blocks can't show the value of the custom fields because it depends on each page. They should show a placeholder instead.

Test pattern syncing overrides

Go to the Site Editor -> Patterns -> Create new synced pattern.
Add a paragraph, go to the Advanced section, and enable "Allow instance overrides".
Add a heading, go to the Advanced section, and enable "Allow instance overrides".
Add an image block, upload or select any media, go to the Advanced section, and enable "Allow instance overrides".
Add a button block, go to the Advanced section, and enable "Allow instance overrides".
Check that you can edit all the attributes.
Go to a page an insert the new pattern.
Modify the values of the blocks.
Check that the updated values are reflected in the frontend

github-actions · 2024-02-13T08:56:40Z

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: SantosGuillamot <santosguillamot@git.wordpress.org>
Co-authored-by: justintadlock <greenshady@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

github-actions · 2024-02-13T09:04:49Z

Size Change: +52 B (0%)

Total Size: 1.71 MB

Filename	Size	Change
`build/block-editor/index.min.js`	251 kB	+9 B (0%)
`build/block-library/index.min.js`	216 kB	+43 B (0%)

ℹ️ View Unchanged

Filename	Size
`build/a11y/index.min.js`	955 B
`build/annotations/index.min.js`	2.69 kB
`build/api-fetch/index.min.js`	2.32 kB
`build/autop/index.min.js`	2.1 kB
`build/blob/index.min.js`	578 B
`build/block-directory/index.min.js`	7.22 kB
`build/block-directory/style-rtl.css`	1.02 kB
`build/block-directory/style.css`	1.02 kB
`build/block-editor/content-rtl.css`	4.35 kB
`build/block-editor/content.css`	4.35 kB
`build/block-editor/default-editor-styles-rtl.css`	381 B
`build/block-editor/default-editor-styles.css`	381 B
`build/block-editor/style-rtl.css`	15.4 kB
`build/block-editor/style.css`	15.3 kB
`build/block-library/blocks/archives/editor-rtl.css`	61 B
`build/block-library/blocks/archives/editor.css`	60 B
`build/block-library/blocks/archives/style-rtl.css`	90 B
`build/block-library/blocks/archives/style.css`	90 B
`build/block-library/blocks/audio/editor-rtl.css`	150 B
`build/block-library/blocks/audio/editor.css`	150 B
`build/block-library/blocks/audio/style-rtl.css`	122 B
`build/block-library/blocks/audio/style.css`	122 B
`build/block-library/blocks/audio/theme-rtl.css`	126 B
`build/block-library/blocks/audio/theme.css`	126 B
`build/block-library/blocks/avatar/editor-rtl.css`	116 B
`build/block-library/blocks/avatar/editor.css`	116 B
`build/block-library/blocks/avatar/style-rtl.css`	104 B
`build/block-library/blocks/avatar/style.css`	104 B
`build/block-library/blocks/block/editor-rtl.css`	305 B
`build/block-library/blocks/block/editor.css`	305 B
`build/block-library/blocks/button/editor-rtl.css`	415 B
`build/block-library/blocks/button/editor.css`	414 B
`build/block-library/blocks/button/style-rtl.css`	627 B
`build/block-library/blocks/button/style.css`	626 B
`build/block-library/blocks/buttons/editor-rtl.css`	337 B
`build/block-library/blocks/buttons/editor.css`	337 B
`build/block-library/blocks/buttons/style-rtl.css`	332 B
`build/block-library/blocks/buttons/style.css`	332 B
`build/block-library/blocks/calendar/style-rtl.css`	239 B
`build/block-library/blocks/calendar/style.css`	239 B
`build/block-library/blocks/categories/editor-rtl.css`	113 B
`build/block-library/blocks/categories/editor.css`	112 B
`build/block-library/blocks/categories/style-rtl.css`	124 B
`build/block-library/blocks/categories/style.css`	124 B
`build/block-library/blocks/code/editor-rtl.css`	53 B
`build/block-library/blocks/code/editor.css`	53 B
`build/block-library/blocks/code/style-rtl.css`	121 B
`build/block-library/blocks/code/style.css`	121 B
`build/block-library/blocks/code/theme-rtl.css`	124 B
`build/block-library/blocks/code/theme.css`	124 B
`build/block-library/blocks/columns/editor-rtl.css`	108 B
`build/block-library/blocks/columns/editor.css`	108 B
`build/block-library/blocks/columns/style-rtl.css`	421 B
`build/block-library/blocks/columns/style.css`	421 B
`build/block-library/blocks/comment-author-avatar/editor-rtl.css`	125 B
`build/block-library/blocks/comment-author-avatar/editor.css`	125 B
`build/block-library/blocks/comment-content/style-rtl.css`	92 B
`build/block-library/blocks/comment-content/style.css`	92 B
`build/block-library/blocks/comment-template/style-rtl.css`	199 B
`build/block-library/blocks/comment-template/style.css`	198 B
`build/block-library/blocks/comments-pagination-numbers/editor-rtl.css`	123 B
`build/block-library/blocks/comments-pagination-numbers/editor.css`	121 B
`build/block-library/blocks/comments-pagination/editor-rtl.css`	222 B
`build/block-library/blocks/comments-pagination/editor.css`	209 B
`build/block-library/blocks/comments-pagination/style-rtl.css`	235 B
`build/block-library/blocks/comments-pagination/style.css`	231 B
`build/block-library/blocks/comments-title/editor-rtl.css`	75 B
`build/block-library/blocks/comments-title/editor.css`	75 B
`build/block-library/blocks/comments/editor-rtl.css`	840 B
`build/block-library/blocks/comments/editor.css`	839 B
`build/block-library/blocks/comments/style-rtl.css`	637 B
`build/block-library/blocks/comments/style.css`	636 B
`build/block-library/blocks/cover/editor-rtl.css`	647 B
`build/block-library/blocks/cover/editor.css`	650 B
`build/block-library/blocks/cover/style-rtl.css`	1.69 kB
`build/block-library/blocks/cover/style.css`	1.68 kB
`build/block-library/blocks/details/editor-rtl.css`	65 B
`build/block-library/blocks/details/editor.css`	65 B
`build/block-library/blocks/details/style-rtl.css`	98 B
`build/block-library/blocks/details/style.css`	98 B
`build/block-library/blocks/embed/editor-rtl.css`	322 B
`build/block-library/blocks/embed/editor.css`	322 B
`build/block-library/blocks/embed/style-rtl.css`	410 B
`build/block-library/blocks/embed/style.css`	410 B
`build/block-library/blocks/embed/theme-rtl.css`	126 B
`build/block-library/blocks/embed/theme.css`	126 B
`build/block-library/blocks/file/editor-rtl.css`	316 B
`build/block-library/blocks/file/editor.css`	316 B
`build/block-library/blocks/file/style-rtl.css`	280 B
`build/block-library/blocks/file/style.css`	281 B
`build/block-library/blocks/file/view.min.js`	324 B
`build/block-library/blocks/footnotes/style-rtl.css`	201 B
`build/block-library/blocks/footnotes/style.css`	199 B
`build/block-library/blocks/form-input/editor-rtl.css`	227 B
`build/block-library/blocks/form-input/editor.css`	227 B
`build/block-library/blocks/form-input/style-rtl.css`	343 B
`build/block-library/blocks/form-input/style.css`	343 B
`build/block-library/blocks/form-submission-notification/editor-rtl.css`	340 B
`build/block-library/blocks/form-submission-notification/editor.css`	340 B
`build/block-library/blocks/form-submit-button/style-rtl.css`	69 B
`build/block-library/blocks/form-submit-button/style.css`	69 B
`build/block-library/blocks/form/view.min.js`	471 B
`build/block-library/blocks/freeform/editor-rtl.css`	2.61 kB
`build/block-library/blocks/freeform/editor.css`	2.61 kB
`build/block-library/blocks/gallery/editor-rtl.css`	947 B
`build/block-library/blocks/gallery/editor.css`	952 B
`build/block-library/blocks/gallery/style-rtl.css`	1.72 kB
`build/block-library/blocks/gallery/style.css`	1.72 kB
`build/block-library/blocks/gallery/theme-rtl.css`	108 B
`build/block-library/blocks/gallery/theme.css`	108 B
`build/block-library/blocks/group/editor-rtl.css`	654 B
`build/block-library/blocks/group/editor.css`	654 B
`build/block-library/blocks/group/style-rtl.css`	57 B
`build/block-library/blocks/group/style.css`	57 B
`build/block-library/blocks/group/theme-rtl.css`	78 B
`build/block-library/blocks/group/theme.css`	78 B
`build/block-library/blocks/heading/style-rtl.css`	189 B
`build/block-library/blocks/heading/style.css`	189 B
`build/block-library/blocks/html/editor-rtl.css`	336 B
`build/block-library/blocks/html/editor.css`	337 B
`build/block-library/blocks/image/editor-rtl.css`	863 B
`build/block-library/blocks/image/editor.css`	862 B
`build/block-library/blocks/image/style-rtl.css`	1.6 kB
`build/block-library/blocks/image/style.css`	1.59 kB
`build/block-library/blocks/image/theme-rtl.css`	126 B
`build/block-library/blocks/image/theme.css`	126 B
`build/block-library/blocks/image/view.min.js`	1.54 kB
`build/block-library/blocks/latest-comments/style-rtl.css`	357 B
`build/block-library/blocks/latest-comments/style.css`	357 B
`build/block-library/blocks/latest-posts/editor-rtl.css`	213 B
`build/block-library/blocks/latest-posts/editor.css`	212 B
`build/block-library/blocks/latest-posts/style-rtl.css`	478 B
`build/block-library/blocks/latest-posts/style.css`	478 B
`build/block-library/blocks/list/style-rtl.css`	88 B
`build/block-library/blocks/list/style.css`	88 B
`build/block-library/blocks/media-text/editor-rtl.css`	266 B
`build/block-library/blocks/media-text/editor.css`	263 B
`build/block-library/blocks/media-text/style-rtl.css`	505 B
`build/block-library/blocks/media-text/style.css`	503 B
`build/block-library/blocks/more/editor-rtl.css`	431 B
`build/block-library/blocks/more/editor.css`	431 B
`build/block-library/blocks/navigation-link/editor-rtl.css`	668 B
`build/block-library/blocks/navigation-link/editor.css`	669 B
`build/block-library/blocks/navigation-link/style-rtl.css`	259 B
`build/block-library/blocks/navigation-link/style.css`	257 B
`build/block-library/blocks/navigation-submenu/editor-rtl.css`	296 B
`build/block-library/blocks/navigation-submenu/editor.css`	295 B
`build/block-library/blocks/navigation/editor-rtl.css`	2.25 kB
`build/block-library/blocks/navigation/editor.css`	2.26 kB
`build/block-library/blocks/navigation/style-rtl.css`	2.24 kB
`build/block-library/blocks/navigation/style.css`	2.23 kB
`build/block-library/blocks/navigation/view.min.js`	1.1 kB
`build/block-library/blocks/nextpage/editor-rtl.css`	395 B
`build/block-library/blocks/nextpage/editor.css`	395 B
`build/block-library/blocks/page-list/editor-rtl.css`	377 B
`build/block-library/blocks/page-list/editor.css`	377 B
`build/block-library/blocks/page-list/style-rtl.css`	175 B
`build/block-library/blocks/page-list/style.css`	175 B
`build/block-library/blocks/paragraph/editor-rtl.css`	235 B
`build/block-library/blocks/paragraph/editor.css`	235 B
`build/block-library/blocks/paragraph/style-rtl.css`	335 B
`build/block-library/blocks/paragraph/style.css`	335 B
`build/block-library/blocks/post-author/style-rtl.css`	175 B
`build/block-library/blocks/post-author/style.css`	176 B
`build/block-library/blocks/post-comments-form/editor-rtl.css`	96 B
`build/block-library/blocks/post-comments-form/editor.css`	96 B
`build/block-library/blocks/post-comments-form/style-rtl.css`	508 B
`build/block-library/blocks/post-comments-form/style.css`	508 B
`build/block-library/blocks/post-content/editor-rtl.css`	74 B
`build/block-library/blocks/post-content/editor.css`	74 B
`build/block-library/blocks/post-date/style-rtl.css`	61 B
`build/block-library/blocks/post-date/style.css`	61 B
`build/block-library/blocks/post-excerpt/editor-rtl.css`	71 B
`build/block-library/blocks/post-excerpt/editor.css`	71 B
`build/block-library/blocks/post-excerpt/style-rtl.css`	141 B
`build/block-library/blocks/post-excerpt/style.css`	141 B
`build/block-library/blocks/post-featured-image/editor-rtl.css`	666 B
`build/block-library/blocks/post-featured-image/editor.css`	662 B
`build/block-library/blocks/post-featured-image/style-rtl.css`	342 B
`build/block-library/blocks/post-featured-image/style.css`	342 B
`build/block-library/blocks/post-navigation-link/style-rtl.css`	215 B
`build/block-library/blocks/post-navigation-link/style.css`	214 B
`build/block-library/blocks/post-template/editor-rtl.css`	99 B
`build/block-library/blocks/post-template/editor.css`	98 B
`build/block-library/blocks/post-template/style-rtl.css`	409 B
`build/block-library/blocks/post-template/style.css`	408 B
`build/block-library/blocks/post-terms/style-rtl.css`	96 B
`build/block-library/blocks/post-terms/style.css`	96 B
`build/block-library/blocks/post-time-to-read/style-rtl.css`	69 B
`build/block-library/blocks/post-time-to-read/style.css`	69 B
`build/block-library/blocks/post-title/style-rtl.css`	100 B
`build/block-library/blocks/post-title/style.css`	100 B
`build/block-library/blocks/preformatted/style-rtl.css`	125 B
`build/block-library/blocks/preformatted/style.css`	125 B
`build/block-library/blocks/pullquote/editor-rtl.css`	135 B
`build/block-library/blocks/pullquote/editor.css`	135 B
`build/block-library/blocks/pullquote/style-rtl.css`	354 B
`build/block-library/blocks/pullquote/style.css`	354 B
`build/block-library/blocks/pullquote/theme-rtl.css`	168 B
`build/block-library/blocks/pullquote/theme.css`	168 B
`build/block-library/blocks/query-pagination-numbers/editor-rtl.css`	122 B
`build/block-library/blocks/query-pagination-numbers/editor.css`	121 B
`build/block-library/blocks/query-pagination/editor-rtl.css`	221 B
`build/block-library/blocks/query-pagination/editor.css`	211 B
`build/block-library/blocks/query-pagination/style-rtl.css`	288 B
`build/block-library/blocks/query-pagination/style.css`	284 B
`build/block-library/blocks/query-title/style-rtl.css`	63 B
`build/block-library/blocks/query-title/style.css`	63 B
`build/block-library/blocks/query/editor-rtl.css`	486 B
`build/block-library/blocks/query/editor.css`	486 B
`build/block-library/blocks/query/view.min.js`	958 B
`build/block-library/blocks/quote/style-rtl.css`	237 B
`build/block-library/blocks/quote/style.css`	237 B
`build/block-library/blocks/quote/theme-rtl.css`	223 B
`build/block-library/blocks/quote/theme.css`	226 B
`build/block-library/blocks/read-more/style-rtl.css`	140 B
`build/block-library/blocks/read-more/style.css`	140 B
`build/block-library/blocks/rss/editor-rtl.css`	149 B
`build/block-library/blocks/rss/editor.css`	149 B
`build/block-library/blocks/rss/style-rtl.css`	289 B
`build/block-library/blocks/rss/style.css`	288 B
`build/block-library/blocks/search/editor-rtl.css`	184 B
`build/block-library/blocks/search/editor.css`	184 B
`build/block-library/blocks/search/style-rtl.css`	614 B
`build/block-library/blocks/search/style.css`	614 B
`build/block-library/blocks/search/theme-rtl.css`	114 B
`build/block-library/blocks/search/theme.css`	114 B
`build/block-library/blocks/search/view.min.js`	478 B
`build/block-library/blocks/separator/editor-rtl.css`	146 B
`build/block-library/blocks/separator/editor.css`	146 B
`build/block-library/blocks/separator/style-rtl.css`	229 B
`build/block-library/blocks/separator/style.css`	229 B
`build/block-library/blocks/separator/theme-rtl.css`	194 B
`build/block-library/blocks/separator/theme.css`	194 B
`build/block-library/blocks/shortcode/editor-rtl.css`	323 B
`build/block-library/blocks/shortcode/editor.css`	323 B
`build/block-library/blocks/site-logo/editor-rtl.css`	754 B
`build/block-library/blocks/site-logo/editor.css`	754 B
`build/block-library/blocks/site-logo/style-rtl.css`	204 B
`build/block-library/blocks/site-logo/style.css`	204 B
`build/block-library/blocks/site-tagline/editor-rtl.css`	86 B
`build/block-library/blocks/site-tagline/editor.css`	86 B
`build/block-library/blocks/site-title/editor-rtl.css`	116 B
`build/block-library/blocks/site-title/editor.css`	116 B
`build/block-library/blocks/site-title/style-rtl.css`	57 B
`build/block-library/blocks/site-title/style.css`	57 B
`build/block-library/blocks/social-link/editor-rtl.css`	184 B
`build/block-library/blocks/social-link/editor.css`	184 B
`build/block-library/blocks/social-links/editor-rtl.css`	682 B
`build/block-library/blocks/social-links/editor.css`	681 B
`build/block-library/blocks/social-links/style-rtl.css`	1.49 kB
`build/block-library/blocks/social-links/style.css`	1.48 kB
`build/block-library/blocks/spacer/editor-rtl.css`	350 B
`build/block-library/blocks/spacer/editor.css`	350 B
`build/block-library/blocks/spacer/style-rtl.css`	48 B
`build/block-library/blocks/spacer/style.css`	48 B
`build/block-library/blocks/table/editor-rtl.css`	395 B
`build/block-library/blocks/table/editor.css`	395 B
`build/block-library/blocks/table/style-rtl.css`	639 B
`build/block-library/blocks/table/style.css`	639 B
`build/block-library/blocks/table/theme-rtl.css`	146 B
`build/block-library/blocks/table/theme.css`	146 B
`build/block-library/blocks/tag-cloud/style-rtl.css`	251 B
`build/block-library/blocks/tag-cloud/style.css`	253 B
`build/block-library/blocks/template-part/editor-rtl.css`	403 B
`build/block-library/blocks/template-part/editor.css`	403 B
`build/block-library/blocks/template-part/theme-rtl.css`	101 B
`build/block-library/blocks/template-part/theme.css`	101 B
`build/block-library/blocks/term-description/style-rtl.css`	111 B
`build/block-library/blocks/term-description/style.css`	111 B
`build/block-library/blocks/text-columns/editor-rtl.css`	95 B
`build/block-library/blocks/text-columns/editor.css`	95 B
`build/block-library/blocks/text-columns/style-rtl.css`	166 B
`build/block-library/blocks/text-columns/style.css`	166 B
`build/block-library/blocks/verse/style-rtl.css`	99 B
`build/block-library/blocks/verse/style.css`	99 B
`build/block-library/blocks/video/editor-rtl.css`	552 B
`build/block-library/blocks/video/editor.css`	555 B
`build/block-library/blocks/video/style-rtl.css`	185 B
`build/block-library/blocks/video/style.css`	185 B
`build/block-library/blocks/video/theme-rtl.css`	126 B
`build/block-library/blocks/video/theme.css`	126 B
`build/block-library/classic-rtl.css`	179 B
`build/block-library/classic.css`	179 B
`build/block-library/common-rtl.css`	1.1 kB
`build/block-library/common.css`	1.1 kB
`build/block-library/editor-elements-rtl.css`	75 B
`build/block-library/editor-elements.css`	75 B
`build/block-library/editor-rtl.css`	12.3 kB
`build/block-library/editor.css`	12.3 kB
`build/block-library/elements-rtl.css`	54 B
`build/block-library/elements.css`	54 B
`build/block-library/reset-rtl.css`	472 B
`build/block-library/reset.css`	472 B
`build/block-library/style-rtl.css`	14.8 kB
`build/block-library/style.css`	14.7 kB
`build/block-library/theme-rtl.css`	688 B
`build/block-library/theme.css`	693 B
`build/block-serialization-default-parser/index.min.js`	1.12 kB
`build/block-serialization-spec-parser/index.min.js`	2.87 kB
`build/blocks/index.min.js`	51.8 kB
`build/commands/index.min.js`	15.6 kB
`build/commands/style-rtl.css`	921 B
`build/commands/style.css`	918 B
`build/components/index.min.js`	226 kB
`build/components/style-rtl.css`	11.8 kB
`build/components/style.css`	11.8 kB
`build/compose/index.min.js`	12.6 kB
`build/core-commands/index.min.js`	2.77 kB
`build/core-data/index.min.js`	72.7 kB
`build/customize-widgets/index.min.js`	12.1 kB
`build/customize-widgets/style-rtl.css`	1.32 kB
`build/customize-widgets/style.css`	1.32 kB
`build/data-controls/index.min.js`	640 B
`build/data/index.min.js`	8.93 kB
`build/date/index.min.js`	17.9 kB
`build/deprecated/index.min.js`	451 B
`build/dom-ready/index.min.js`	324 B
`build/dom/index.min.js`	4.65 kB
`build/edit-post/classic-rtl.css`	544 B
`build/edit-post/classic.css`	545 B
`build/edit-post/index.min.js`	25.1 kB
`build/edit-post/style-rtl.css`	5.63 kB
`build/edit-post/style.css`	5.62 kB
`build/edit-site/index.min.js`	212 kB
`build/edit-site/style-rtl.css`	15.8 kB
`build/edit-site/style.css`	15.9 kB
`build/edit-widgets/index.min.js`	17.3 kB
`build/edit-widgets/style-rtl.css`	4.21 kB
`build/edit-widgets/style.css`	4.21 kB
`build/editor/index.min.js`	61.8 kB
`build/editor/style-rtl.css`	5.43 kB
`build/editor/style.css`	5.43 kB
`build/element/index.min.js`	4.83 kB
`build/escape-html/index.min.js`	537 B
`build/format-library/index.min.js`	7.89 kB
`build/format-library/style-rtl.css`	478 B
`build/format-library/style.css`	477 B
`build/hooks/index.min.js`	1.55 kB
`build/html-entities/index.min.js`	448 B
`build/i18n/index.min.js`	3.58 kB
`build/interactivity/file.min.js`	447 B
`build/interactivity/image.min.js`	1.67 kB
`build/interactivity/index.min.js`	12.7 kB
`build/interactivity/navigation.min.js`	1.24 kB
`build/interactivity/query.min.js`	740 B
`build/interactivity/router.min.js`	1.29 kB
`build/interactivity/search.min.js`	618 B
`build/is-shallow-equal/index.min.js`	527 B
`build/keyboard-shortcuts/index.min.js`	1.74 kB
`build/keycodes/index.min.js`	1.46 kB
`build/list-reusable-blocks/index.min.js`	2.11 kB
`build/list-reusable-blocks/style-rtl.css`	836 B
`build/list-reusable-blocks/style.css`	836 B
`build/media-utils/index.min.js`	2.9 kB
`build/modules/importmap-polyfill.min.js`	12.2 kB
`build/notices/index.min.js`	948 B
`build/nux/index.min.js`	2 kB
`build/nux/style-rtl.css`	735 B
`build/nux/style.css`	732 B
`build/patterns/index.min.js`	5.74 kB
`build/patterns/style-rtl.css`	540 B
`build/patterns/style.css`	539 B
`build/plugins/index.min.js`	1.8 kB
`build/preferences-persistence/index.min.js`	2.05 kB
`build/preferences/index.min.js`	2.82 kB
`build/preferences/style-rtl.css`	698 B
`build/preferences/style.css`	700 B
`build/primitives/index.min.js`	975 B
`build/priority-queue/index.min.js`	1.52 kB
`build/private-apis/index.min.js`	1 kB
`build/react-i18n/index.min.js`	623 B
`build/react-refresh-entry/index.min.js`	9.47 kB
`build/react-refresh-runtime/index.min.js`	6.78 kB
`build/redux-routine/index.min.js`	2.7 kB
`build/reusable-blocks/index.min.js`	2.72 kB
`build/reusable-blocks/style-rtl.css`	243 B
`build/reusable-blocks/style.css`	243 B
`build/rich-text/index.min.js`	10.4 kB
`build/router/index.min.js`	1.79 kB
`build/server-side-render/index.min.js`	1.95 kB
`build/shortcode/index.min.js`	1.39 kB
`build/style-engine/index.min.js`	2.08 kB
`build/token-list/index.min.js`	582 B
`build/url/index.min.js`	3.72 kB
`build/vendors/inert-polyfill.min.js`	2.48 kB
`build/vendors/react-dom.min.js`	41.8 kB
`build/vendors/react.min.js`	4.02 kB
`build/viewport/index.min.js`	957 B
`build/warning/index.min.js`	249 B
`build/widgets/index.min.js`	7.21 kB
`build/widgets/style-rtl.css`	1.15 kB
`build/widgets/style.css`	1.16 kB
`build/wordcount/index.min.js`	1.02 kB

_{compressed-size-action}

justintadlock

This change seems to be working well for me.

Also testing with a custom binding source:

I think longer term, it'd be good to be able to set the "connected" message via custom source.

SantosGuillamot · 2024-02-13T16:50:30Z

I think longer term, it'd be good to be able to set the "connected" message via custom source.

I totally agree. The main issue right now is that the editor APIs are not public because we have to explore that part better. On the other hand, I believe we could use a more generic message and allow sources to override it. I included it as part of this issue to improve the UX: link.

…#58961) * Disable editing if source is undefined * Add tests when source is undefined

youknowriad · 2024-02-20T14:22:06Z

I just cherry-picked this PR to the more/backports-for-beta3 branch to get it included in the next release: 50244c6

…#58961) * Disable editing if source is undefined * Add tests when source is undefined

SantosGuillamot added 2 commits February 13, 2024 09:52

Disable editing if source is undefined

96007f1

Add tests when source is undefined

64ee61e

SantosGuillamot requested review from ellatrix, fluiddot, dcalhoun, kevin940726, Mamaduka, artemiomorales, michalczaplinski and ajitbohra as code owners February 13, 2024 08:56

SantosGuillamot requested a review from justintadlock February 13, 2024 08:56

justintadlock approved these changes Feb 13, 2024

View reviewed changes

SantosGuillamot mentioned this pull request Feb 13, 2024

Block Bindings: Polish the current UX when block attributes are bound #58978

Closed

SantosGuillamot merged commit 1a2a1d3 into trunk Feb 13, 2024
71 checks passed

SantosGuillamot deleted the fix/disable-bindings-editing-when-source-is-undefined branch February 13, 2024 16:49

github-actions bot added this to the Gutenberg 17.8 milestone Feb 13, 2024

youknowriad pushed a commit that referenced this pull request Feb 20, 2024

Block Bindings: Fix disable bindings editing when source is undefined (…

50244c6

…#58961) * Disable editing if source is undefined * Add tests when source is undefined

youknowriad removed the Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Feb 20, 2024

youknowriad mentioned this pull request Feb 20, 2024

More/backports for beta 2 #59208

Merged

youknowriad added the Backported to WP Core Pull request that has been successfully merged into WP Core label Feb 20, 2024

youknowriad pushed a commit that referenced this pull request Feb 20, 2024

Block Bindings: Fix disable bindings editing when source is undefined (…

51c5b29

…#58961) * Disable editing if source is undefined * Add tests when source is undefined

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Block Bindings: Fix disable bindings editing when source is undefined #58961

Block Bindings: Fix disable bindings editing when source is undefined #58961

SantosGuillamot commented Feb 13, 2024

github-actions bot commented Feb 13, 2024 •

edited

Loading

github-actions bot commented Feb 13, 2024

justintadlock left a comment

SantosGuillamot commented Feb 13, 2024

youknowriad commented Feb 20, 2024

Block Bindings: Fix disable bindings editing when source is undefined #58961

Block Bindings: Fix disable bindings editing when source is undefined #58961

Conversation

SantosGuillamot commented Feb 13, 2024

What?

Why?

How?

Testing Instructions

In a page

In a template

Test pattern syncing overrides

github-actions bot commented Feb 13, 2024 • edited Loading

github-actions bot commented Feb 13, 2024

justintadlock left a comment

Choose a reason for hiding this comment

SantosGuillamot commented Feb 13, 2024

youknowriad commented Feb 20, 2024

github-actions bot commented Feb 13, 2024 •

edited

Loading