Revert "Block Hooks: Set ignoredHookedBlocks metada attr upon insertion" #58969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ockham
added
[Feature] Block API
|
Size Change: -208 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
ockham
requested review from
ellatrix,
ajitbohra,
ryanwelcher,
juanmaguitar,
fabiankaegy and
ndiego
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ockham
added
Backport to Gutenberg RC
ockham
deleted the
revert-58553-add/ignored-hooked-blocks-metadata-attr-upon-insertion
branch
|
cc/ @MaggieCabrera @youknowriad @getdave
|
|
Thank you for flagging @ockham. |
|
@ockham This is too late for Beta 1. How important is this one for Gutenberg 17.7? (ideally Gutenberg 17.7 is the same as beta1) |
I think it should go into GB 17.7 to prevent the
Makes sense. In this case, I think it's okay to deviate a bit from this principle and land it in Beta 2, if that allows us to remove something we won't be needing in 6.5 😊 |
|
Yes, it's fine to include in Beta2 and it's fine if it's in Gutenberg for one release IMO. |
16 tasks
|
@youknowriad @getdave Is it possible that this didn't make it into Beta 2? (I don't see it over at #58969.) |
|
@ockham you're right, I don't see it there. It's weird because we used the "cherry pick" command, we need to check why this PR was missed and if we missed more PRs. Unfortunately, I feel like it means that it won't be in beta2 but we'll make sure it's included in beta3. |
|
There's actually a lot of PRs that were missed by the script https://github.com/WordPress/gutenberg/issues?q=label%3A%22Backport+to+WP+Beta%2FRC%22+is%3Aclosed that's a bit concerning to me, I don't know why the script didn't pick these PRs. Anyway, we'll include them in beta 3 |
|
I just cherry-picked this PR to the more/backports-for-beta3 branch to get it included in the next release: d50c836 |
youknowriad
removed
the
Backport to WP 6.7 Beta/RC
|
Ok, so it turns out that the script we used for backports had missed a lot of PRs, so I'm actually going to do the backports again for beta 2 which means this PR will be included in beta2 |
youknowriad
added
the
Backported to WP Core
|
Related #59210 |
|
Note that this revert PR did not make it into the 17.7 release. However, it is in 17.8 RC1 and will be include in the 17.8 release next week. |
creativecoder
removed
the
Backport to Gutenberg RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #58553
This has been superseded by WordPress/wordpress-develop#6087. As such, I'd like to revert this PR in order not to introduce a new selector (
getHookedBlocks) that we won't actually need.Note that this code has so far only been part of 17.7 RC1, so
getHookedBlockshasn't been part of any stable releases yet.Once this PR has been merged, it should be cherry-picked to the
release/17.7branch, and included in the next package sync for WP 6.5. I'll set the relevant labels.cc/ @gziolo @tjcafferkey