Restore patterns e2e tests #59024
Merged
Restore patterns e2e tests #59024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
the
[Type] Automated Testing
|
Size Change: -154 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 05b7f5e. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7912726598
|
kevin940726
reviewed
Feb 15, 2024
| patterns.list | ||
| .getByRole( 'heading', { name: 'My pattern' } ) | ||
| .getByRole( 'button', { name: 'My pattern', exact: true } ) | ||
| patterns.itemsList.getByText( 'My pattern', { |
There was a problem hiding this comment.
Do we have a heading role for this text for accessibility?
There was a problem hiding this comment.
They are just divs.. I don't know if there is a better way to get them..
There was a problem hiding this comment.
I think there should be a heading role or something similar for the data view so that screen readers know what the grid is about. This can be a follow-up accessibility task for the data views though!
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Follow up of: #58139
This PR restores and updates the patterns tests.