Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interactivity API: Remove data-wp-interactive object for core/router. #59030

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

cbravobernal
Copy link
Contributor

@cbravobernal cbravobernal commented Feb 14, 2024

What?

Refactor to use the simplified string version.

Testing Instructions

  1. In the site editor, deactivate "Force page reload" for the Query block.
  2. Visit the homepage.
  3. In the browser dev tools, add a network throttling (e.g. Slow 3G).
  4. In the Query block, navigate to the Next page.
  5. Ensure the loading bar appears and start an animation.
  6. Ensure the loading bar disappears when the next page is loaded.

Backport PR

WordPress/wordpress-develop#6111

@cbravobernal cbravobernal added [Type] Code Quality Issues or PRs that relate to code quality Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta [Packages] Interactivity /packages/interactivity labels Feb 14, 2024
@cbravobernal cbravobernal self-assigned this Feb 14, 2024
Copy link

github-actions bot commented Feb 14, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: c4rl0sbr4v0 <cbravobernal@git.wordpress.org>
Co-authored-by: gziolo <gziolo@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress.

If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged.

If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack.

Thank you! ❤️

View changed files
❔ lib/compat/wordpress-6.5/interactivity-api/class-wp-interactivity-api.php

Copy link

Flaky tests detected in 4e8730a.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7905735665
📝 Reported issues:

Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good refactoring 👍🏻

Completely unrelated to this PR, but it would be good to investigate why the e2e test for the Navigation block fails from time to time:

Screenshot 2024-02-15 at 09 41 57

@cbravobernal
Copy link
Contributor Author

Good refactoring 👍🏻

Completely unrelated to this PR, but it would be good to investigate why the e2e test for the Navigation block fails from time to time:

Screenshot 2024-02-15 at 09 41 57

Will check in a follow up PR.

@cbravobernal cbravobernal merged commit 7853838 into trunk Feb 15, 2024
66 checks passed
@cbravobernal cbravobernal deleted the refactor/use-string-namespace-core-router branch February 15, 2024 10:02
@github-actions github-actions bot added this to the Gutenberg 17.8 milestone Feb 15, 2024
youknowriad pushed a commit that referenced this pull request Feb 20, 2024
Co-authored-by: c4rl0sbr4v0 <cbravobernal@git.wordpress.org>
Co-authored-by: gziolo <gziolo@git.wordpress.org>
@youknowriad
Copy link
Contributor

I just cherry-picked this PR to the more/backports-for-beta3 branch to get it included in the next release: 18c62df

@youknowriad youknowriad removed the Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Feb 20, 2024
@youknowriad youknowriad added the Backported to WP Core Pull request that has been successfully merged into WP Core label Feb 20, 2024
youknowriad pushed a commit that referenced this pull request Feb 20, 2024
Co-authored-by: c4rl0sbr4v0 <cbravobernal@git.wordpress.org>
Co-authored-by: gziolo <gziolo@git.wordpress.org>
@creativecoder creativecoder added the [Feature] Interactivity API API to add frontend interactivity to blocks. label Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backported to WP Core Pull request that has been successfully merged into WP Core [Feature] Interactivity API API to add frontend interactivity to blocks. [Packages] Interactivity /packages/interactivity [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants