Patterns: Avoid showing block removal warning when deleting a pattern instance that has overrides #59044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion rules on overridden blocks
glendaviesnz
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +19 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 72b5b6b. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7909094805
|
talldan
approved these changes
Feb 15, 2024
Comment on lines
+143
to
+151
| const parentPatternBlocks = | ||
| select.getBlockParentsByBlockName( | ||
| clientId, | ||
| 'core/block' | ||
| ); | ||
| // We only need to run this check when editing the original pattern, not pattern instances. | ||
| if ( parentPatternBlocks?.length > 0 ) { | ||
| continue; | ||
| } |
There was a problem hiding this comment.
I guess another way is to only have the pattern overrides rule when within a pattern.
No real preference here, but I think it might affect the follow up that's underway.
talldan
changed the title
talldan
changed the title
getdave
pushed a commit
that referenced
this pull request
Feb 20, 2024
…lock deletion rules (#59044) * Check we are not within a pattern instance before running block deletion rules on overridden blocks * Make comment more explanatory Co-authored-by: glendaviesnz <glendaviesnz@git.wordpress.org> Co-authored-by: talldan <talldanwp@git.wordpress.org>
|
I just cherry-picked this PR to the cherry-pick-beta-2 branch to get it included in the next release: 3f62ea1 |
getdave
removed
the
Backport to WP 6.7 Beta/RC
youknowriad
pushed a commit
that referenced
this pull request
Feb 20, 2024
…lock deletion rules (#59044) * Check we are not within a pattern instance before running block deletion rules on overridden blocks * Make comment more explanatory Co-authored-by: glendaviesnz <glendaviesnz@git.wordpress.org> Co-authored-by: talldan <talldanwp@git.wordpress.org>
talldan
changed the title
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Checks we are not within a pattern instance before running block deletion rules.
Why?
Currently a user gets a warning then they try to delete a pattern block if it contains blocks with content overrides, but this warning only makes sense if the user is editing the original pattern.
How?
Checks to make sure the block does not have a parent of
core/blockbefore running the deletion prompt.Testing Instructions
Edit originaland then try deleting one of the overridden blocks and make sure the warning displaysTesting Instructions for Keyboard
Screenshots or screencast
delete-fix.mp4