Global styles revisions Controller: return single revision only when it matches the parent id

[ramonjd]

What?

Brings global styles revisions controller Gutenberg_REST_Global_Styles_Revisions_Controller_6_5 in line with the changes from:

• Revisions Controller: return single revision only when it matches the parent id wordpress-develop#5655

This change is required as WP_REST_Global_Styles_Revisions_Controller doesn't inherit WP_REST_Revisions_Controller.

Core backport:

• Global styles revisions Controller: return single revision only when it matches the parent id wordpress-develop#6108

Trac ticket

• https://core.trac.wordpress.org/ticket/59810

Why? And how?

WordPress/wordpress-develop#5655 explains:

This PR adds a condition to get_item that checks the revision parent id against the supplied parent id.

If it doesn't match, the method returns a 404.

This is to ensure that get_item does not return a revision whose parent does not match the parent route fragment.

Testing Instructions

npm run test:unit:php:base -- --filter Gutenberg_REST_Global_Styles_Revisions_Controller_Test

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ramonjd <ramonopoly@git.wordpress.org>
Co-authored-by: andrewserong <andrewserong@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[github-actions]

This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress.

If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged.

If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack.

Thank you! ❤️

View changed files

❔ lib/compat/wordpress-6.5/class-gutenberg-rest-global-styles-revisions-controller-6-5.php
❔ phpunit/class-gutenberg-rest-global-styles-revisions-controller-test.php

[github-actions]

Flaky tests detected in 5bc68dc.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7909900259
📝 Reported issues:

• [Flaky Test] create a submenu #59007 in /test/e2e/specs/editor/blocks/navigation.spec.js
• [Flaky Test] list view should correctly reflect navigation items' structure #58980 in /test/e2e/specs/editor/blocks/navigation-list-view.spec.js
• [Flaky Test] show a list view in the inspector controls #58983 in /test/e2e/specs/editor/blocks/navigation-list-view.spec.js
• [Flaky Test] submenu converts to link automatically #58981 in /test/e2e/specs/editor/blocks/navigation.spec.js

[andrewserong]

LGTM! ✨

[github-actions]

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

• Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core.
• Labels found: [Type] Enhancement, REST API Interaction, Global Styles, Backport from WordPress Core.

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

[creativecoder]

Note that as part of curating the Gutenberg 17.8 changelog, I added the label [Type] Enhancement to this PR to better categorize it.

Please let me know if there is a different label that would be a better fit.