Rich text: fix link paste for internal paste #59063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
added
the
[Feature] Rich Text
ellatrix
requested review from
fluiddot,
dcalhoun,
kevin940726 and
Mamaduka
as code owners
|
Size Change: +287 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 5313b31. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7916318807
|
mcsf
approved these changes
Feb 15, 2024
| @@ -58,13 +58,35 @@ export function usePasteHandler( props ) { | |||
| const isInternal = | |||
| event.clipboardData.getData( 'rich-text' ) === 'true'; | |||
|
|
|||
| function pasteInline( content ) { | |||
| const transformed = formatTypes.reduce( | |||
| ( accumlator, { __unstablePasteRule } ) => { | |||
There was a problem hiding this comment.
While we're here, we can fix the typo:
Suggested change
| ( accumlator, { __unstablePasteRule } ) => { | |
| ( accumulator, { __unstablePasteRule } ) => { |
There was a problem hiding this comment.
What do you mean, you didn't know about the abbreviation accum'lator? 😄
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
mcsf
added
the
Backport to WP 6.7 Beta/RC
youknowriad
added a commit
that referenced
this pull request
Feb 20, 2024
Co-authored-by: ellatrix <ellatrix@git.wordpress.org> Co-authored-by: mcsf <mcsf@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: annezazu <annezazu@git.wordpress.org>
|
I just cherry-picked this PR to the more/backports-for-beta3 branch to get it included in the next release: 2958043 |
youknowriad
removed
the
Backport to WP 6.7 Beta/RC
youknowriad
added
the
Backported to WP Core
youknowriad
added a commit
that referenced
this pull request
Feb 20, 2024
Co-authored-by: ellatrix <ellatrix@git.wordpress.org> Co-authored-by: mcsf <mcsf@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: annezazu <annezazu@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #57487
Alternative to #58786
Why?
Added an e2e test that fails in trunk:
How?
The transforms must be run for external as well as internal paste.
Testing Instructions
See test and issue linked: type out a link, copy it, then paste it over a word.
Testing Instructions for Keyboard
Screenshots or screencast