feat: Toggle mobile Quote block citation #59097
Merged
Commits on Feb 15, 2024
-
refactor: Align
RichTextrefs with web implementationPreviously, the native `RichText` implementation relied upon a bespoke `setRef` prop to forward refs to the native rich text editor instance (i.e., Aztec). While this worked fine for contexts where `RichText` was used for the native platform only, it diverged from the web `RichText`. This divergence created incompatibility for the context of a component running on both web and native which passed a ref to `RichText`. This refactor aligns the native `RichText` with the web implementation so that refs may be passed under a single, unified `ref` prop. The ref is then forwarded onto the native rich text editor instance, as it was before.
-
fix: Avoid passing incompatible styles to native components
The `display: block` style attribute is not supported by React Native and results in an error.
-
test: Fix Quote block citation interaction
The citation input is now hidden behind a toggle button.
-
feat: Toggle Pullquote block citation
Align with the web implementation by hiding the citation input behind a toggle button.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.