Elements: Make editor selector match theme.json and frontend #59167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronrobertshaw
added
[Type] Code Quality
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +14 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 62c4e69. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7956105590
|
ramonjd
approved these changes
Feb 20, 2024
There was a problem hiding this comment.
LGTM
This PR:
2024-02-21.10.10.14.mp4
Trunk:
Therefore, is this change worth the extra little bit of bloat to the CSS?
I can only offer my opinion. I like things when they're consistent. That's why I repeatedly buy the same shoes and briefs - I want to know what I'm stepping into. More germane to this issue, I think having consistent classnames assists debugging, especially when switching between frontend and editor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses issue flagged in: #59163
What?
Makes the link element selector consistent between theme.json, the frontend elements block support, and the site editor.
Note: There should be no functional change in the editor as the editor currently renders buttons as
divelements for the rich text editing, so haven't run into the conflict with links styles like the frontend did.Therefore, is this change worth the extra little bit of bloat to the CSS?
Why?
The selector used should be consistent unless there is a good reason not to be. Being consistent here might mean avoiding unexpected issues down the line if the way element styles are handled changes.
How?
Make the JS selector consistent with the one in theme.json and the elements block support.
Testing Instructions
a:where(:not(.wp-element-button))selector