Gallery: Set the 'defaultBlock' setting for inner blocks #59168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Enhancement
|
Size Change: -63 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in f55788b. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7956330211
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Thanks for putting this PR together @Mamaduka 👍
I think I'm missing something as I see the same behaviour on trunk as with the changes in this PR.
| Trunk | This PR |
|---|---|
Screen.Recording.2024-02-20.at.12.00.04.pm.mp4 |
Screen.Recording.2024-02-20.at.12.01.02.pm.mp4 |
Could you perhaps expand on the the PR description and test instructions?
|
Oh, sorry for the confusion, @aaronrobertshaw. The behavior should be the same, so we confirm there's no regression. I'm matching Block settings to Button/Navigation blocks and preparing them for #59168. |
1 task
aaronrobertshaw
approved these changes
Feb 20, 2024
There was a problem hiding this comment.
I'm matching Block settings to Button/Navigation blocks and preparing them for #59168.
Ah, thanks for clarifying 👍
I've added a note on this to the PR description for posterity.
The behavior should be the same, so we confirm there's no regression.
In that case, I can happily say I couldn't spot any differences between trunk and this PR 😁
LGTM 🚢
|
Thank you, @aaronrobertshaw 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
PR sets the 'defaultBlock' setting for the Gallery block in preparation for #59162.
Why?
The setting will be needed for #59162.
Testing Instructions
There should be no difference in behaviour between trunk and this PR.
Testing Instructions for Keyboard
Same.