Interactivity API: Improve context merges using proxies #59187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DAreRodz
added
[Type] Bug
|
Size Change: +148 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 9c7b3a5. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7992783284
|
DAreRodz
force-pushed
the
fix/interactivity-api-context-merge-navigation
branch
from
fcae882
to
43037bc
Compare
DAreRodz
requested review from
kevin940726,
Mamaduka,
ntwb,
nerrad,
ajitbohra and
luisherranz
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
|
||
| const mergeDeepSignals = ( target, source, overwrite ) => { | ||
| const isPlainObject = ( item ) => |
There was a problem hiding this comment.
This will be similar as the one in store.ts
#59039
Should we move it to another file to share same code in different files?
There was a problem hiding this comment.
Yeah, maybe we could move it to utils.js. 🤔
47 tasks
gziolo
added
Backport to WP 6.7 Beta/RC
cbravobernal
force-pushed
the
fix/interactivity-api-context-merge-navigation
branch
from
0ec816e
to
9c7b3a5
Compare
getdave
pushed a commit
that referenced
this pull request
Feb 27, 2024
* First attempt using proxies * Simplify context logic * Return true from proxy `set` trap * Update wp-context and wp-each implementation * Rename `isObject` to `isPlainObject` * Refactor and document proxifyContext * Add test for new parent properties * Do not proxify assigned objects * Set the item after proxifying the context * Rename contextIgnores to contextAssignedObjects * Add comment to `udpateSignals` * Fix context values when navigating back and forward * Add more tests for navigations * Update tests to cover a tricky case * Update comment * Fix context definition in navigation block * Add test for object overwritten * Update changelog Co-authored-by: DAreRodz <darerodz@git.wordpress.org> Co-authored-by: c4rl0sbr4v0 <cbravobernal@git.wordpress.org>
|
I just cherry-picked this PR to the cherry-pick-wp-6-5-beta-3 branch to get it included in the next release: 8374560 |
getdave
added
Backported to WP Core
9 tasks
getdave
pushed a commit
that referenced
this pull request
Feb 27, 2024
* First attempt using proxies * Simplify context logic * Return true from proxy `set` trap * Update wp-context and wp-each implementation * Rename `isObject` to `isPlainObject` * Refactor and document proxifyContext * Add test for new parent properties * Do not proxify assigned objects * Set the item after proxifying the context * Rename contextIgnores to contextAssignedObjects * Add comment to `udpateSignals` * Fix context values when navigating back and forward * Add more tests for navigations * Update tests to cover a tricky case * Update comment * Fix context definition in navigation block * Add test for object overwritten * Update changelog Co-authored-by: DAreRodz <darerodz@git.wordpress.org> Co-authored-by: c4rl0sbr4v0 <cbravobernal@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Reimplements the context merging algorithm using proxies.
Contexts are defined using the
data-wp-contextdirective. A context can inherit properties from upper contexts defined in the DOM. To achieve that, contexts are "merged" top-down.Why?
It solves a couple of inconsistencies, like changes in inherited context not being reflected in child contexts and issues during navigations.
These issues are:
data-wp-contextare inherited. That means newly added properties to parent contexts don't appear in children.How?
Implementing a function called
proxifyContext. It receives two arguments: thedeepSignalinstance for the current context and the inherited context. The proxy makes inherited properties appear like they were defined in the current context.