Font collection pagination: add min height to avoid infinite number #59241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
matiasbenedetto
added
[Type] Bug
|
Size Change: +7 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in bb7e637. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/8004151967
|
t-hamano
approved these changes
Feb 22, 2024
packages/edit-site/src/components/global-styles/font-library-modal/font-collection.js
Outdated
Show resolved
Hide resolved
t-hamano
added
the
Backport to WP 6.7 Beta/RC
Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com>
|
@matiasbenedetto, If you rebase this PR, it should pass performance tests. See #59259 |
9 tasks
getdave
added
Backported to WP Core
|
I just manually cherry-picked this PR to the cherry-pick-wp-6-5-beta-3 branch to get it included in the next release. |
getdave
pushed a commit
that referenced
this pull request
Feb 27, 2024
…59241) * Add min height to avoid infinite number * improve syntax Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com> --------- Co-authored-by: matiasbenedetto <mmaattiiaass@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: carolinan <poena@git.wordpress.org> # Conflicts: # packages/edit-site/src/components/global-styles/font-library-modal/font-collection.js
getdave
pushed a commit
that referenced
this pull request
Feb 27, 2024
…59241) * Add min height to avoid infinite number * improve syntax Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com> --------- Co-authored-by: matiasbenedetto <mmaattiiaass@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: carolinan <poena@git.wordpress.org> # Conflicts: # packages/edit-site/src/components/global-styles/font-library-modal/font-collection.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add min height to the modal
Fixes: #59235
Why?
to avoid infinite number
How?
adding a constant with the min height.
Testing Instructions
see: #59235
Screenshots or screencast
2024-02-21.11-26-58.mp4