Introduce section container selection when assembling patterns (zoom out mode) #59249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
commented
Feb 21, 2024
getdave
commented
Feb 21, 2024
ajlende
reviewed
Feb 24, 2024
packages/block-editor/src/components/block-list/disable-non-main-blocks.js
Outdated
Show resolved
Hide resolved
ajlende
reviewed
Feb 24, 2024
ajlende
reviewed
Feb 24, 2024
ajlende
force-pushed
the
add/enable-zoom-out-mode-within-main
branch
from
e1f846b
to
969787e
Compare
|
Size Change: +1.6 kB (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
getdave
commented
Feb 24, 2024
getdave
commented
Feb 24, 2024
getdave
commented
Feb 24, 2024
draganescu
force-pushed
the
add/enable-zoom-out-mode-within-main
branch
from
86ee03f
to
5718e9f
Compare
ajlende
reviewed
Feb 24, 2024
packages/block-editor/src/components/block-list/use-zoom-out-block-editing-mode.js
Outdated
Show resolved
Hide resolved
This comment was marked as outdated.
This comment was marked as outdated.
draganescu
force-pushed
the
add/enable-zoom-out-mode-within-main
branch
from
e7b0cf7
to
83bb613
Compare
|
I have rebased this. It needed some manual conflict res so I hope nothing is broken. It does test very well. |
draganescu
force-pushed
the
add/enable-zoom-out-mode-within-main
branch
from
fc571b4
to
bb81502
Compare
richtabor
added
[Feature] Zoom Out
[Type] Enhancement
|
This tests actually quite well. @getdave I'm curious, what we need to do to get this tidied up? |
7 tasks
One thing to explore would be to keep these accessible within List View, so you can still select + shuffle headers and footers; we'd just keep them pinned to the top and bottom, per #60054. |
3 tasks
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
scruffian
force-pushed
the
add/enable-zoom-out-mode-within-main
branch
2 times, most recently
from
c377098
to
85d3814
Compare
scruffian
reviewed
Mar 27, 2024
ajlende
force-pushed
the
add/enable-zoom-out-mode-within-main
branch
from
0f5170f
to
9e5640a
Compare
ajlende
reviewed
Apr 9, 2024
packages/editor/src/components/provider/use-block-editor-settings.js
Outdated
Show resolved
Hide resolved
ajlende
reviewed
Apr 9, 2024
ajlende
force-pushed
the
add/enable-zoom-out-mode-within-main
branch
from
baec558
to
3af6938
Compare
ajlende
reviewed
Apr 9, 2024
| return null; | ||
| } | ||
|
|
||
| if ( [ 'post', 'page' ].includes( contextPostType ) ) { |
There was a problem hiding this comment.
Copied from #60609 (comment).
These are not the only content types so I'd prefer if remove this. I'd rather do the following algorithm instead:
1- If mode = "template-locked": look for post-content block
2- If mode is not "template-locked', look for the "main" group block
3- fallback to top level. (undefined section container I guess)
packages/editor/src/components/provider/use-block-editor-settings.js
Outdated
Show resolved
Hide resolved
youknowriad
reviewed
Apr 10, 2024
youknowriad
reviewed
Apr 11, 2024
draganescu
approved these changes
Apr 11, 2024
There was a problem hiding this comment.
The original PR has been iterated on to:
- transform the concept of section id from a state concept to a setting in block editor
- make sure the block editor remains decoupled conceptually from editor
- apply block editting modes as efficiently as possible
- make the zoom out mode display an assembly like interaction, if there is a section root found and even if there is no section root found
- make sure the assembly interaction works for pages and templates alike
- remove unrelated updates, such as the behavior of list view
I think this can safely land, the new block editor setting is locked and there doesn't seem to be any remaining conceptual, performance or code quality concern.
ellatrix
reviewed
Apr 11, 2024
ellatrix
reviewed
Apr 11, 2024
| @@ -70,6 +73,7 @@ const BLOCK_EDITOR_SETTINGS = [ | |||
| 'postContentAttributes', | |||
| 'postsPerPage', | |||
| 'readOnly', | |||
| 'sectionRootClientId', | |||
There was a problem hiding this comment.
Does it need to be declared here if it's locked?
There was a problem hiding this comment.
It looks like it doesn't need to be declared here if it isn't part of the parent settings that we want to include.
|
This still isn't testing very well for me in a lot of scenarios. On most pages, the post content block is selectable instead of the content which is unexpected. 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR introduces the notion of a section root block, much like we have the grouping block. This is the root block of all sections. By default this root is a group block with the tag
main, but in certain contexts editors would want to set it to something else. For example the site editor while editing a page will set the section root block to be the post content block since that's where the sections are.In Zoomed out mode:
Testing Instructions
Screenshots or screencast
Screen.Capture.on.2024-02-21.at.16-52-43.mp4