Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation: Add missing empty space to print out valid HTML. #59255

Merged
merged 2 commits into from
Feb 22, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/block-library/src/navigation/index.php
Original file line number Diff line number Diff line change
@@ -561,7 +561,7 @@ private static function get_nav_element_directives( $is_interactive ) {
)
);
$nav_element_directives = '
data-wp-interactive="core/navigation"'
data-wp-interactive="core/navigation" '
. $nav_element_context;

return $nav_element_directives;

Unchanged files with check annotations Beta

editor.canvas.locator(
`role=textbox[name="Navigation link text"i] >> text="Custom link"`
)
).toBeVisible( { timeout: 10000 } ); // allow time for network request.

Check failure on line 114 in test/e2e/specs/editor/blocks/navigation.spec.js

GitHub Actions / Playwright - 2

[chromium] › editor/blocks/navigation.spec.js:91:3 › Navigation block › As a user I want the navigation block to fallback to the best possible default › default to the only existing classic menu if there are no block menus

1) [chromium] › editor/blocks/navigation.spec.js:91:3 › Navigation block › As a user I want the navigation block to fallback to the best possible default › default to the only existing classic menu if there are no block menus Error: Timed out 10000ms waiting for expect(locator).toBeVisible() Locator: frameLocator('[name="editor-canvas"]').locator('role=textbox[name="Navigation link text"i]').locator('text="Custom link"') Expected: visible Received: hidden Call log: - expect.toBeVisible with timeout 10000ms - waiting for frameLocator('[name="editor-canvas"]').locator('role=textbox[name="Navigation link text"i]').locator('text="Custom link"') 112 | `role=textbox[name="Navigation link text"i] >> text="Custom link"` 113 | ) > 114 | ).toBeVisible( { timeout: 10000 } ); // allow time for network request. | ^ 115 | 116 | const postId = await editor.publishPost(); 117 | // Check the block in the frontend. at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/blocks/navigation.spec.js:114:6
const postId = await editor.publishPost();
// Check the block in the frontend.