Performance tests: make site editor performance test backwards compatible #59266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes the test backwards compatible until the performance tests base commit is updated.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ramonjd
added
the
[Type] Automated Testing
youknowriad
approved these changes
Feb 22, 2024
|
Size Change: -240 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
Mamaduka
reviewed
Feb 22, 2024
|
Flaky tests detected in 6fb5d1f. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/8000827177
|
Mamaduka
approved these changes
Feb 22, 2024
|
To confirm, backporting this into the 17.8 rc should allow performance tests to pass, is that correct? |
creativecoder
added
the
Backport to Gutenberg RC
|
Backport both #59259 and this one. Just to be safe. |
creativecoder
pushed a commit
that referenced
this pull request
Feb 23, 2024
…ible (#59266) * Update Performance tests base branch after #59259 This commit makes the test backwards compatible until the performance tests base commit is updated. * use locator Co-authored-by: ramonjd <ramonopoly@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
|
I just cherry-picked this PR to the release/17.8 branch to get it included in the next release: 4b436f5 |
creativecoder
removed
the
Backport to Gutenberg RC
youknowriad
added a commit
that referenced
this pull request
Mar 4, 2024
…ible (#59266) * Update Performance tests base branch after #59259 This commit makes the test backwards compatible until the performance tests base commit is updated. * use locator Co-authored-by: ramonjd <ramonopoly@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
youknowriad
added a commit
that referenced
this pull request
Mar 4, 2024
…ible (#59266) * Update Performance tests base branch after #59259 This commit makes the test backwards compatible until the performance tests base commit is updated. * use locator Co-authored-by: ramonjd <ramonopoly@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why? How?
Alternative to #59265
Update Performance tests after #59259
This commit makes the test backwards compatible until the performance tests base commit is updated.
See: #59259 (comment)
Testing Instructions
CI checks should pass.