Interactivity API: Prevent unwanted subscriptions to inherited context props #59273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DAreRodz
requested review from
kevin940726,
Mamaduka,
ntwb,
nerrad,
ajitbohra and
luisherranz
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
DAreRodz
added
[Type] Bug
|
Size Change: -9 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
cbravobernal
requested changes
Feb 22, 2024
Co-authored-by: Carlos Bravo <37012961+c4rl0sbr4v0@users.noreply.github.com>
Co-authored-by: Carlos Bravo <37012961+c4rl0sbr4v0@users.noreply.github.com>
|
Flaky tests detected in 5cf4137. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/8005117130
|
DAreRodz
deleted the
fix/interactivity-api-context-merge-prop-subscription
branch
getdave
pushed a commit
that referenced
this pull request
Feb 27, 2024
…t props (#59273) * Add failing test * Fix subscription issue * Fix typo Co-authored-by: Carlos Bravo <37012961+c4rl0sbr4v0@users.noreply.github.com> * Change multiline comment to block comment Co-authored-by: Carlos Bravo <37012961+c4rl0sbr4v0@users.noreply.github.com> * Update test name Co-authored-by: Carlos Bravo <37012961+c4rl0sbr4v0@users.noreply.github.com> --------- Co-authored-by: DAreRodz <darerodz@git.wordpress.org> Co-authored-by: c4rl0sbr4v0 <cbravobernal@git.wordpress.org>
|
I just cherry-picked this PR to the cherry-pick-wp-6-5-beta-3 branch to get it included in the next release: a51059c |
getdave
added
Backported to WP Core
9 tasks
getdave
pushed a commit
that referenced
this pull request
Feb 27, 2024
…t props (#59273) * Add failing test * Fix subscription issue * Fix typo Co-authored-by: Carlos Bravo <37012961+c4rl0sbr4v0@users.noreply.github.com> * Change multiline comment to block comment Co-authored-by: Carlos Bravo <37012961+c4rl0sbr4v0@users.noreply.github.com> * Update test name Co-authored-by: Carlos Bravo <37012961+c4rl0sbr4v0@users.noreply.github.com> --------- Co-authored-by: DAreRodz <darerodz@git.wordpress.org> Co-authored-by: c4rl0sbr4v0 <cbravobernal@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Makes directives subscribe to inherited context props only when they don't exist in the current context.
Why?
This prevents unwanted subscriptions to changes in inherited properties that are overwritten in the local context, avoiding potential issues with directives that are executed based on property changes.
How?
Adding a condition when returning the final value. When the property exists in the current context, it is not read from the inherited one, thus preventing the subscription.
I've added a test that reproduces the problem and then fixed the code.