Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URLPopover: restore min-width style #59274

Merged
merged 1 commit into from
Feb 22, 2024
Merged

URLPopover: restore min-width style #59274

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/block-editor/src/components/url-popover/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@
text-overflow: ellipsis;
white-space: nowrap;
margin-right: $grid-unit-10;
min-width: 150px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you recall what the value was before?

I think the input field here is 300px. Maybe keep that?
Screenshot 2024-02-22 at 14 28 01

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you recall what the value was before?

The previous value was 150px and I have restored the same value in this PR.

See: https://github.com/WordPress/gutenberg/pull/57608/files#diff-49bee8a5008288296ba2faca8ec5cb424a7c7d56790d40cf7f28cc6966409662L74

// Avoids the popover from growing too wide when the URL is long.
// See https://github.com/WordPress/gutenberg/issues/58599
max-width: $modal-min-width;
Expand Down
Loading