[Data Views][Grid Layout] Adding semantics and basic keyboard navigation #59279
+197
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
andrewhayward
added
[Focus] Accessibility (a11y)
andrewhayward
changed the title
andrewhayward
requested review from
youknowriad,
jorgefilipecosta and
ntsekouras
4 tasks
|
Size Change: +815 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in f4363e9. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/8006619235
|
andrewhayward
changed the title
ntsekouras
reviewed
Mar 1, 2024
| const [ resizeListener, { width: totalWidth } ] = useResizeObserver(); | ||
|
|
||
| const referenceCell = | ||
| gridRef?.current?.querySelector( '[role="gridcell"]' ) || {}; |
There was a problem hiding this comment.
Instead of querying the DOM, would it make sense to add a ref in Grid component and then do something like: getComputedStyle(gridRef.current)?.getPropertyValue('grid-template-columns')? Then we could derive the column count.
|
Thanks for splitting this work in smaller PRs! One of my main concerns is focusing non interactive elements, which seemed weird to me(for example the |
|
We may want to rebase this from |
|
@andrewhayward what're your thoughts on this alternative example for keyboard navigation? The arrow keys are still used to navigate them, but there's a single tab stop for grid items — tabbing doesn't go through all of them. In our case, we also have controls after the grid list (pagination), so I find this model would be a good fit for DataViews's Grid layout: it allows users to reach pagination quickly and it's similar to how list layout will work as well. Gravacao.do.ecra.2024-03-11.as.16.06.15.mov |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also: #59188
What?
Adds structural semantics to grid layout, and improves keyboard navigation.
Why?
Grid layouts are currently semantically ambiguous, with no structural scaffolding to denote which fields relate to each other.
How?
role="grid"role="gridcell"role="row"elementsTesting Instructions
Testing Instructions for Keyboard