Columns: Correctly recalculate column widths when the column count is increased by more than 2 at once #59301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… increased by more than 2 at once
t-hamano
added
[Type] Bug
|
Size Change: +9 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 7493f61. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/8014892129
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
andrewserong
approved these changes
Feb 23, 2024
There was a problem hiding this comment.
Nicely done @t-hamano, this is testing well for me. Thanks for adding the test coverage, too! 🎉
|
@andrewserong Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #58824
What?
This PR will correctly update the percentage width of each column to add up to 100% when two or more columns are added.
For example, if the widths of each of the four columns are
10%,20%,30%, and40%, and the number of columns is increased to 6, each column width will be:8.33%,16.67%,25%,33.33%,16.67%,16.67%( ❌ Total116.67%)6.67%,13.33%,20%,26.66%,16.67%,16.67%( ✅ Total100%)Why?
If all columns have percentage widths and a column is added, the width of the existing columns will be recalculated to account for the width of the newly added column. However, it appears that the current logic did not take into account the scenario where more than one column was added.
How?
I have taken into account the logic so that no matter how many newly added columns there are, the total value will always be 100%.
Additionally, since this scenario cannot be covered by unit tests, I added e2e tests.
Testing Instructions
Screenshots or screencast
825cf8e61553f1bd4c4dae1a0ecc294a.mp4