Shadow: Fix layout collapse when indicator is selected #59309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Regression
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +10 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 520dbf7. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/8017552333
|
madhusudhand
approved these changes
Feb 23, 2024
There was a problem hiding this comment.
Thank you for the fix @t-hamano. It tests as expected. No layout shift is observed.
|
Sorry, I forgot to update the props when merging 😅 |
getdave
pushed a commit
that referenced
this pull request
Feb 27, 2024
|
I just cherry-picked this PR to the cherry-pick-wp-6-5-beta-3 branch to get it included in the next release: 6198eb0 |
getdave
added
Backported to WP Core
9 tasks
getdave
pushed a commit
that referenced
this pull request
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up #58828
What?
This PR fixes layout corruption when an indicator is selected in a shadow popover.
Why?
As far as I can tell, this problem is caused by the indicator margin added in #58828.
How?
I removed the indicator margin and applied a flex layout. This is a minimal fix for WP6.5. In the future, popover width/gap and swatch width should be made into CSS variables and a calculated grid layout should be applied, like in the duotone picker.
Testing Instructions