Dynamically set border panel label based on the controls available #59358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madhusudhand
added
[Type] Bug
madhusudhand
requested review from
vcanales,
jasmussen,
mikachan and
carolinan
madhusudhand
requested review from
tellthemachines and
ellatrix
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +79 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
mikachan
reviewed
Feb 26, 2024
There was a problem hiding this comment.
I've given this a smoke test and all the scenarios are working well for me. I tested with a blank block theme so there were no theme presets that could influence the settings.
appearanceToolsenabled in theme.json: title is "Border & Shadow" ✅appearanceToolsdisabled in theme.json: the border panel doesn't show ✅- Setting
shadow.defaultPresetsto false: title is "Border" ✅ - Setting
shadow.defaultPresetsto true but disabling all border controls: title is "Shadow" ✅
mikachan
approved these changes
Feb 27, 2024
|
I just cherry-picked this PR to the cherry-pick-wp-6-5-beta-3 branch to get it included in the next release: 65a8496 |
getdave
added
Backported to WP Core
9 tasks
getdave
pushed a commit
that referenced
this pull request
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This fixes #58907
As suggested in this comment label of the panel is set based on the controls available/enabled
Following are the scenarios:
Testing Instructions
Test the below mentioned scenarios both in global styles and block settings (of image or button).
Test: border ✅, shadow ✅
Enable appearanceTools in
theme.json. Both should be enabled.Test: border ✅ , shadow ❌
Test: border ❌ , shadow ✅
Test: border ❌ , shadow ❌
Note: even if appearanceTools is off, when theme defines shadows, shadows UI appears to show theme defined shadows. This now becomes scenario 3.