[RNMobile] Add error boundry handling for Android #59385

jhnstn · 2024-02-26T22:32:25Z

What?

Adds Android support to #59221

Why?

How?

Testing Instructions

See #59221 for testing

Testing Instructions for Keyboard

Screenshots or screencast

jhnstn · 2024-02-26T22:34:22Z

.../src/main/java/org/wordpress/mobile/ReactNativeGutenbergBridge/GutenbergBridgeJS2Parent.java

@@ -4,7 +4,6 @@

 import com.facebook.react.bridge.ReadableArray;
 import com.facebook.react.bridge.ReadableMap;
-import com.facebook.react.bridge.WritableMap;


I believe Android Studio removed this when it linted the file.

jhnstn · 2024-02-26T22:38:04Z

...java/org/wordpress/mobile/ReactNativeGutenbergBridge/RNReactNativeGutenbergBridgeModule.java

+        mGutenbergBridgeJS2Parent.logException(exception, logExceptionCallback);
+    }
+
+   private LogExceptionCallback onLogExceptionCallback(final Callback jsCallback) {


I'm following the same encapsulation used for other callbacks in the bridge, such as ConnectionStatusCallback.

github-actions · 2024-02-26T22:51:45Z

Flaky tests detected in a16c50f.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/8056529535
📝 Reported issues:

[Flaky Test] can remove menu items #58985 in /test/e2e/specs/editor/blocks/navigation-list-view.spec.js

github-actions · 2024-03-01T14:47:14Z

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core.
Labels found: Mobile App - i.e. Android or iOS, Mobile App - Automation.

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

fluiddot

@jhnstn I took a brief look at the PR and shared some initial comments related to parsing the exception. Feel free to omit them in case you are already aware.

...bridge/src/main/java/org/wordpress/mobile/ReactNativeGutenbergBridge/GutenbergJsException.kt

…-boundary/android

github-actions · 2024-03-06T21:12:50Z

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: jhnstn <jsnjohnston@git.wordpress.org>
Co-authored-by: fluiddot <carlosgprim@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

fluiddot · 2024-03-07T10:17:03Z

@jhnstn the CI job React Native E2E Tests (Android) failed with the following error:

file:///Users/runner/work/gutenberg/gutenberg/packages/react-native-editor/android/app/src/main/java/com/gutenberg/MainApplication.kt:88:84
Object is not abstract and does not implement abstract member public abstract fun logException(p0: GutenbergJsException!, p1: GutenbergBridgeJS2Parent.LogExceptionCallback!):
Unit defined in org.wordpress.mobile.ReactNativeGutenbergBridge.GutenbergBridgeJS2Parent

I think we are missing implementing LogExceptionCallback in the demo app.

UPDATE: Fixed in f3211da.

fluiddot

LGTM 🎊 !

* Add parse function to send exceptions over the RN bridge * Add RN bridge function to log exceptions to the host app * Add error boundary to blocks * Add error boundary at editor level * Log exceptions from error boundary components * Remove `in_app` stack trace parameter * Remove `getPopSize` The parameter `framesToPop` was dropped in RN version 0.62 (facebook/react-native@8bc02fd). * Simplify functions from `parseException` * Rename exception tag to `gutenberg_mobile_version` * Add `gutenbergDidRequestLogException` bridge function to demo app * Trigger callback upon sending JS exception * Format `RNReactNativeGutenbergBridge` * Update inline comments * Merge `reverseEntries` logic into `parseStacktrace` * Set second param of `parseException` (context and tags) as optional * Add unit tests of `parseException` * Add inline comment to `getReactNativeContext` * Add typing for JavaScript exception in bridge * Fix param type in `gutenbergDidRequestLogException` * Update `gutenbergDidRequestLogException` implementation of demo app * Rename `JSException` to avoid disambiguation with Crash Logging service * Add `actions` prop to `Warning` component * Allow extra styles in `Warning` component * Implement copy buttons in Error boundary component * Fix style import path in error boundary component * Change GutenbergJSException `function` param to non-optional * Rename JSException param to `message` * Rename GutenbergJSException param to `message` * Update `react-native-editor` changelog * Update unit tests of `parseException` * [RNMobile] Add error boundry handling for Android (#59385) * Add logException to Android bridge * Add logException to Android demo app * Add GutenbergJsException data class * Update logException to use data class and return bool to callback * integrate exception handling in the glue code * remove past tense 'did' * Refactor exception processing * lint * Add `logException` bridge function in demo app * Update stacktrace parsing on Android --------- Co-authored-by: Carlos Garcia <fluiddot@gmail.com> --------- Co-authored-by: Jason Johnston <jhnstn@users.noreply.github.com>

…ress#59221) * Add parse function to send exceptions over the RN bridge * Add RN bridge function to log exceptions to the host app * Add error boundary to blocks * Add error boundary at editor level * Log exceptions from error boundary components * Remove `in_app` stack trace parameter * Remove `getPopSize` The parameter `framesToPop` was dropped in RN version 0.62 (facebook/react-native@8bc02fd). * Simplify functions from `parseException` * Rename exception tag to `gutenberg_mobile_version` * Add `gutenbergDidRequestLogException` bridge function to demo app * Trigger callback upon sending JS exception * Format `RNReactNativeGutenbergBridge` * Update inline comments * Merge `reverseEntries` logic into `parseStacktrace` * Set second param of `parseException` (context and tags) as optional * Add unit tests of `parseException` * Add inline comment to `getReactNativeContext` * Add typing for JavaScript exception in bridge * Fix param type in `gutenbergDidRequestLogException` * Update `gutenbergDidRequestLogException` implementation of demo app * Rename `JSException` to avoid disambiguation with Crash Logging service * Add `actions` prop to `Warning` component * Allow extra styles in `Warning` component * Implement copy buttons in Error boundary component * Fix style import path in error boundary component * Change GutenbergJSException `function` param to non-optional * Rename JSException param to `message` * Rename GutenbergJSException param to `message` * Update `react-native-editor` changelog * Update unit tests of `parseException` * [RNMobile] Add error boundry handling for Android (WordPress#59385) * Add logException to Android bridge * Add logException to Android demo app * Add GutenbergJsException data class * Update logException to use data class and return bool to callback * integrate exception handling in the glue code * remove past tense 'did' * Refactor exception processing * lint * Add `logException` bridge function in demo app * Update stacktrace parsing on Android --------- Co-authored-by: Carlos Garcia <fluiddot@gmail.com> --------- Co-authored-by: Jason Johnston <jhnstn@users.noreply.github.com>

jhnstn commented Feb 26, 2024

View reviewed changes

jhnstn added Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) Mobile App - Automation Label used to initiate Mobile App PR Automation labels Mar 1, 2024

jhnstn added 5 commits March 1, 2024 09:51

Add logException to Android bridge

48e7fe2

Add logException to Android demo app

41f8c1f

Add GutenbergJsException data class

38518a7

Update logException to use data class and return bool to callback

8755437

integrate exception handling in the glue code

b61200e

wpmobilebot mentioned this pull request Mar 1, 2024

[RNMobile] Add error boundry handling for Android wordpress-mobile/gutenberg-mobile#6690

Closed

jhnstn force-pushed the rnmobile/update/error-boundary/android branch from a16c50f to b61200e Compare March 1, 2024 15:30

fluiddot reviewed Mar 1, 2024

View reviewed changes

jhnstn added 2 commits March 4, 2024 14:42

remove past tense 'did'

b956669

Refactor exception processing

050de88

jhnstn mentioned this pull request Mar 6, 2024

[Gutenberg] Add error boundary components and exception logging wordpress-mobile/WordPress-Android#20359

Merged

13 tasks

Merge branch 'rnmobile/add/error-boundary' into rnmobile/update/error…

7664490

…-boundary/android

jhnstn marked this pull request as ready for review March 6, 2024 21:12

lint

96f53be

fluiddot added 2 commits March 7, 2024 12:07

Add logException bridge function in demo app

f3211da

Update stacktrace parsing on Android

d8c72e1

fluiddot approved these changes Mar 7, 2024

View reviewed changes

fluiddot merged commit 49f32e7 into rnmobile/add/error-boundary Mar 7, 2024
48 of 57 checks passed

fluiddot deleted the rnmobile/update/error-boundary/android branch March 7, 2024 15:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[RNMobile] Add error boundry handling for Android #59385

[RNMobile] Add error boundry handling for Android #59385

jhnstn commented Feb 26, 2024 •

edited

Loading

jhnstn Feb 26, 2024

jhnstn Feb 26, 2024

github-actions bot commented Feb 26, 2024

github-actions bot commented Mar 1, 2024

fluiddot left a comment

github-actions bot commented Mar 6, 2024

fluiddot commented Mar 7, 2024 •

edited

Loading

fluiddot left a comment

[RNMobile] Add error boundry handling for Android #59385

[RNMobile] Add error boundry handling for Android #59385

Conversation

jhnstn commented Feb 26, 2024 • edited Loading

What?

Why?

How?

Testing Instructions

Testing Instructions for Keyboard

Screenshots or screencast

jhnstn Feb 26, 2024

Choose a reason for hiding this comment

jhnstn Feb 26, 2024

Choose a reason for hiding this comment

github-actions bot commented Feb 26, 2024

github-actions bot commented Mar 1, 2024

fluiddot left a comment

Choose a reason for hiding this comment

github-actions bot commented Mar 6, 2024

fluiddot commented Mar 7, 2024 • edited Loading

fluiddot left a comment

Choose a reason for hiding this comment

jhnstn commented Feb 26, 2024 •

edited

Loading

fluiddot commented Mar 7, 2024 •

edited

Loading