Avoid loading theme fonts twice and assume they were already resolved by the font face resolver. #59421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… by the font face resolver. This allows us to remove some related to guess the url of theme fonts.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -38 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
matiasbenedetto
added
[Type] Bug
There was a problem hiding this comment.
This looks good to me and tests well.
Testing notes:
- Installed
adventurertheme - Uploaded Open Sans
- Replaced all the fonts faces to use open sans in headings, text, etc, etc
- Saved, reloaded site editor
- Confirmed that the theme font's
@font-facedefinitions appeared in the site editor markup. - Confirmed the fonts loaded once I opened the font library
- Reset to default styles
- Confirmed that open-sans loaded once I opened the font library.
packages/edit-site/src/components/global-styles/font-library-modal/utils/index.js
Outdated
Show resolved
Hide resolved
youknowriad
added
the
Backport to WP 6.7 Beta/RC
Co-authored-by: Peter Wilson <519727+peterwilsoncc@users.noreply.github.com>
|
This is working for me as well. I tested that installing fonts still work as expected without having to reload pages to get the styles or anything. |
youknowriad
approved these changes
Feb 28, 2024
matiasbenedetto
changed the title
youknowriad
added a commit
that referenced
this pull request
Mar 4, 2024
… by the font face resolver. (#59421) * Avoid loading theme fonts again and assume they were already resolved by the font face resolver. This allows us to remove some related to guess the url of theme fonts. * fix comment text Co-authored-by: Peter Wilson <519727+peterwilsoncc@users.noreply.github.com> --------- Co-authored-by: matiasbenedetto <mmaattiiaass@git.wordpress.org> Co-authored-by: peterwilsoncc <peterwilsoncc@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: swissspidy <swissspidy@git.wordpress.org>
|
I just cherry-picked this PR to the update/packages-6.5-rc1 branch to get it included in the next release: 30c4f7d |
youknowriad
added
Backported to WP Core
youknowriad
added a commit
that referenced
this pull request
Mar 4, 2024
… by the font face resolver. (#59421) * Avoid loading theme fonts again and assume they were already resolved by the font face resolver. This allows us to remove some related to guess the url of theme fonts. * fix comment text Co-authored-by: Peter Wilson <519727+peterwilsoncc@users.noreply.github.com> --------- Co-authored-by: matiasbenedetto <mmaattiiaass@git.wordpress.org> Co-authored-by: peterwilsoncc <peterwilsoncc@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: swissspidy <swissspidy@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Why?
How?
If we deal with theme fonts:
Testing Instructions
Screenshots or screencast
The theme fonts should render as expected here:
