Avoid creating font families without font faces. #59436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we ae trying to create a new font family with font faces but the font family was created in the database but the font faces failed because of the file system permissions, the font family is removed from the database.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +30 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
matiasbenedetto
added
[Type] Bug
mikachan
approved these changes
Feb 28, 2024
matiasbenedetto
deleted the
add/avoid-creating-font-families-without-font-faces
branch
|
@matiasbenedetto Do you want to backport this to the WP beta? |
matiasbenedetto
added
the
Backport to WP 6.7 Beta/RC
|
Yes, I added the corresponding label. Thanks for asking. |
youknowriad
pushed a commit
that referenced
this pull request
Mar 4, 2024
If we ae trying to create a new font family with font faces but the font family was created in the database but the font faces failed because of the file system permissions, the font family is removed from the database. --- Co-authored-by: matiasbenedetto <mmaattiiaass@git.wordpress.org> Co-authored-by: mikachan <mikachan@git.wordpress.org>
|
I just cherry-picked this PR to the update/packages-6.5-rc1 branch to get it included in the next release: 6c04972 |
youknowriad
added
Backported to WP Core
youknowriad
pushed a commit
that referenced
this pull request
Mar 4, 2024
If we ae trying to create a new font family with font faces but the font family was created in the database but the font faces failed because of the file system permissions, the font family is removed from the database. --- Co-authored-by: matiasbenedetto <mmaattiiaass@git.wordpress.org> Co-authored-by: mikachan <mikachan@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Avoid creating font families without font faces.
Why?
There could be cases where the user can create font families but no font faces. For example, the user could be able to have permission to create font families in the database, but the filesystem permissions could be wrong in their server. This could lead to font families without any font face.
There are explorations around hiding the install-related UI when the user doesn't have permission to write the fonts folder. Those explorations haven't landed yet; this safe-guard probably won't hurt when those changes land and may still be useful in some cases, such as uploading font faces with wrong mime types.
How?
With this change, if the user is installing a font family but the installation of all font faces failed, the font family just created is removed from the database.
Testing Instructions
wp-content/fontsfolder.Screenshots or screencast
The screencasts are feature installing fonts in 2 scenarios:
Compare the behavior in
trunk2024-02-28.14-34-15.mp4
vs the be behavior in this branch:
2024-02-28.14-36-20.mp4