Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format PHP inline comments correctly #59452

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Conversation

tellthemachines
Copy link
Contributor

What?

Follow-up from #58991 (review); props @peterwilsoncc for spotting this!

I also fixed a few instances I recently added to lib/block-supports/layout.php.

Testing Instructions

This shouldn't impact the code itself at all 😅

Testing Instructions for Keyboard

Screenshots or screencast

Copy link

github-actions bot commented Feb 29, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: tellthemachines <isabel_brison@git.wordpress.org>
Co-authored-by: andrewserong <andrewserong@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress.

If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged.

If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack.

Thank you! ❤️

View changed files
❔ lib/block-supports/layout.php
❔ lib/class-wp-theme-json-gutenberg.php
❔ lib/global-styles-and-settings.php
❔ lib/script-loader.php

Copy link
Contributor

@andrewserong andrewserong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✨

@tellthemachines tellthemachines merged commit 0b5cd48 into trunk Feb 29, 2024
64 checks passed
@tellthemachines tellthemachines deleted the fix/inline-comments branch February 29, 2024 04:19
@github-actions github-actions bot added this to the Gutenberg 17.9 milestone Feb 29, 2024
@tellthemachines tellthemachines added the Needs PHP backport Needs PHP backport to Core label Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs PHP backport Needs PHP backport to Core [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants