Rich text: fix typing into empty flex element #59473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +2 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
|
@getdave @youknowriad @annezazu @colorful-tones How do you all feel about including this in 6.5? It is a bug fix of something that has been broken for a while but I think is worth including in the bugfix phase. |
|
I'm ok with that, it's a very isolated fix. |
ellatrix
added
the
Backport to WP 6.7 Beta/RC
|
I'm in agreement, especially if it's an isolated fix as Ella says! |
|
Do it. 🚀 |
|
I think it's fine the change seems low impact. |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
fabiankaegy
approved these changes
Mar 1, 2024
youknowriad
added a commit
that referenced
this pull request
Mar 4, 2024
Co-authored-by: ellatrix <ellatrix@git.wordpress.org> Co-authored-by: fabiankaegy <fabiankaegy@git.wordpress.org> Co-authored-by: annezazu <annezazu@git.wordpress.org> Co-authored-by: colorful-tones <colorful-tones@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: Mgrmjp <miikkamakela@git.wordpress.org>
|
I just cherry-picked this PR to the update/packages-6.5-rc1 branch to get it included in the next release: 43b12ee |
youknowriad
added
Backported to WP Core
youknowriad
added a commit
that referenced
this pull request
Mar 4, 2024
Co-authored-by: ellatrix <ellatrix@git.wordpress.org> Co-authored-by: fabiankaegy <fabiankaegy@git.wordpress.org> Co-authored-by: annezazu <annezazu@git.wordpress.org> Co-authored-by: colorful-tones <colorful-tones@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: Mgrmjp <miikkamakela@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #59192.
Why?
Fixes #59192.
How?
Input goes inside the placeholder when the wrapper element has display flex. We can fix that by considering any text inside the placeholder element to be content.
Create an empty paragraph and set display to flex. Typing inside it should work.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast