Remove preview from Font Family & Font Face APIs #59569
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress. If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged. If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack. Thank you! ❤️ View changed files❔ lib/compat/wordpress-6.5/fonts/class-wp-rest-font-faces-controller.php ❔ lib/compat/wordpress-6.5/fonts/class-wp-rest-font-families-controller.php |
|
Size Change: +10 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
mikachan
added
[Type] Enhancement
65 tasks
|
At this point, with the preview arg being part of the font family and font face API endpoints in WP 6.5, I think we should close this PR and create an issue if this is still something we want to do. Deprecating the preview property will be more involved: we'll need to extend the controller classes from core to override them in Gutenberg with the necessary changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Remove the preview property from the Font Face and Font Family APIs
Don't send the preview property when creating Font Face and Font Family APIs from the client
Why?
The preview has limited value once a font is installed. (Not NO value, but limited. Any font INSTALLED and ACTIVATED will already have the font assets loaded in the browser and the preview isn't needed. Only fonts INSTALLED and NOT ACTIVATED would get a SMALL benefit from using previews.). However since previews are SVG assets they aren't available to be imported into WordPress due to security concerns.
Rather than managing preview assets (at all) for fonts that have been installed instead just remove that from something that we need to be concerned with.
Previews remain unchanged for Font Faces and Font Families that are in a Font Collection.
Testing Instructions
Using the Install Fonts tab make sure the previews are rendered with SVG files.
Install a Font and go to the Library Tab
Ensure the font that was just installed has a preview rendered with the font resource.