Site Editor: Fix Global Styles outdated output #59628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Bug
youknowriad
requested review from
getdave,
jasmussen,
tellthemachines,
andrewserong and
annezazu
youknowriad
commented
Mar 6, 2024
| }, [ | ||
| hasBlockGapSupport, | ||
| hasFallbackGapSupport, | ||
| mergedConfig, | ||
| disableLayoutStyles, | ||
| isTemplate, |
There was a problem hiding this comment.
Adding this line is the fix here. I did some additional cleanup to the hook though.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
jasmussen
approved these changes
Mar 6, 2024
|
Size Change: +7 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
|
Wonderful, thank you for fixing this up quickly! 🎉 |
|
This bug was identified as an Issue during the RC period and is a critical fix to ensure correct CSS output for WP 6.5. |
getdave
pushed a commit
that referenced
this pull request
Mar 11, 2024
Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: jasmussen <joen@git.wordpress.org> Co-authored-by: andrewserong <andrewserong@git.wordpress.org>
|
I just cherry-picked this PR to the pick/wp-65-rc-2 branch to get it included in the next release: 984ede0 |
getdave
added
Backported to WP Core
getdave
pushed a commit
that referenced
this pull request
Mar 12, 2024
Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: jasmussen <joen@git.wordpress.org> Co-authored-by: andrewserong <andrewserong@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #59593
What?
When navigating in the site editor, in some conditions, the right global styles CSS is not output properly. This PR fixes that
How?
The issue happens because there's a flag
isTemplateused to compute the right global styles and when navigating in the site editor, sometimes the flag moves from "undefined" to an actual value set and when that happens, the right global styles were not being regenerated.Testing Instructions
1- Open the site editor with tt4
2- Notice the padding around the template header (in the actual canvas)
3- Navigate to Page 404 in the site editor
4- Go back to the home page
5- In trunk the padding disappears, in this PR the padding remains.