-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Components: Fix unwanted ToggleGroupControl backdrop vertical animation #59642
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @acicovic. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From a components point of view 🚀
- Verified that
ToggleGroupControl
still works well in Storybook, and no regressions to the backdrop animation are introduced - Verified that
ToggleGroupControl
still works well in the editor, and no regressions to the backdrop animation are introduced - Verified that
ToggleGroupControl
continues to work with "reduce motion" enabled
Will leave the parse.ly testing for folks who know better!
@vaurdan has validated that the fix works for us! |
Thanks, everyone! |
What?
This PR updates the
ToggleGroupControl
backdrop animation to be contained inside the component.Why?
To fix an edge case where the backdrop animation will sometimes incorrectly animate outside of the
ToggleGroupControl
component if another surrounding component changes height. I'm unable to repro this in Gutenberg, but it was easily reproducible with the Parse.ly plugin.How?
We're utilizing
layout
andlayoutRoot
to minimize surrounding content changes impact, as recommended by the official docs.Testing Instructions
ToggleGroupControl
still works well in Storybook and this introduces no regressions to the backdrop animation.ToggleGroupControl
still works well in the editor (font size picker in typography settings for example) - verify this introduces no regressions to the backdrop animation.Testing Instructions for Keyboard
None
Screenshots or screencast
Before:
Screen.Recording.2024-03-06.at.15.48.29.mov
After:
Screen.Recording.2024-03-06.at.15.45.52.mov