Global Styles: Presets: Show the default empty variation as well as the other presets #59717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scruffian
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
4 tasks
|
Size Change: +145 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
scruffian
force-pushed
the
fix/59574
branch
2 times, most recently
from
92ca9ec
to
c5a44d7
Compare
|
I think this is a very important step that could open up solutions for multiple problems. One of those is the fact that whenever a user makes changes to their global styles, those get lost if the user changes to a different style variation. This makes sense in a way since the user changes are being saved on top of the default variation, which we had no way to go back to before this PR besides undoing the user changes. I wonder if the next step is to create a "user" variation under the presets that is independent of the default presets and can persist regardless of the default preset chosen by the user. |
MaggieCabrera
approved these changes
Mar 18, 2024
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Mar 27, 2024
…he other presets (WordPress#59717) * Show the default empty variation as well as the other presets * remove unconnected change * filter out duplicate color variations and leave the default alone * add a comment * rename hooks * Make default translatable Co-authored-by: scruffian <scruffian@git.wordpress.org> Co-authored-by: MaggieCabrera <onemaggie@git.wordpress.org> Co-authored-by: richtabor <richtabor@git.wordpress.org> Co-authored-by: ramonjd <ramonopoly@git.wordpress.org> Co-authored-by: matiasbenedetto <mmaattiiaass@git.wordpress.org>
This was referenced Apr 29, 2024
|
Somehow, it looks like this functionality was reverted. The most recent GB release looks like this. Note that the default color "empty" variation is no longer displayed. 
|
|
It seems to be working OK on the latest trunk. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This shows the default preset as well as the variations...
Why?
...so that users can set them back to the original settings that came with the theme.
How?
Add empty default variations to the ones we fetch from the store.
Fixes #59574
Testing Instructions
Screenshots or screencast