Fix getEntityRecordsTotalPages when per_page is not provided
#59983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…relies on the defaults from REST API
ntsekouras
added
[Type] Bug
|
Size Change: +33 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
Mamaduka
approved these changes
Mar 19, 2024
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Mar 27, 2024
…relies on the defaults from REST API (WordPress#59983) Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
There is a bug reported by @Mamaduka where
getEntityRecordsTotalPagescan returnNaNif the query doesn't provideper_pagerelies on the defaults from REST API.How?
If the
per_pageargument is not provided, we can fallback to the header of the response, since it should update properly with other changes of the query. We should still derive the result if theper_pageis provided, because it's not part of the stable key, where we keep the information in state.Testing Instructions
per_pageargument is provided. You can test this easily in pages list(DataViews) and update therows per page.per_pageand observe thatgetEntityRecordsTotalPagesreturns the proper result.