Update Snapshots for line height #60041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
scruffian
force-pushed
the
update/line-height
branch
from
51f64e9 to
2337b74
Compare
scruffian
added
the
[Type] Code Quality
|
Size Change: 0 B Total Size: 1.71 MB ℹ️ View Unchanged
|
mirka
reviewed
Mar 20, 2024
There was a problem hiding this comment.
I forgot to push this commit before merging, sorry.
No worries, the unit tests failures are a non-blocking check at the moment, so it's easy to overlook the snapshot failures when you have auto-merge enabled. I've done it before 😅
Can you update the rest of the snapshot failures too? All the other ones also stem from the changes in #60028, if I'm not mistaken.
Co-authored-by: Lena Morita <lena@jaguchi.com>
Thanks. Done! |
tyxla
reviewed
Mar 20, 2024
ramonjd
approved these changes
Mar 20, 2024
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Mar 27, 2024
* Update snapshots to fix JS tests and match changes from WordPress#60028 * Add changelog entry --------- Co-authored-by: scruffian <scruffian@git.wordpress.org> Co-authored-by: ramonjd <ramonopoly@git.wordpress.org> Co-authored-by: mirka <0mirka00@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds the snapshots that were missing in #60028
Why?
I forgot to push this commit before merging, sorry.
How?
Updates the snapshots
Testing Instructions
Do the e2e tests pass?
Screenshots or screencast