DataViews: remove the enumeration type as redundant
#60084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oandregal
requested review from
ntsekouras,
youknowriad,
mcsf and
jorgefilipecosta
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
oandregal
added
[Feature] DataViews
|
Size Change: -19 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
oandregal
force-pushed
the
remove/enumeration-type-dataviews
branch
from
b0abc16 to
52c2f1f
Compare
oandregal
commented
Mar 21, 2024
| isPrimary, | ||
| } ); | ||
| } | ||
| const isPrimary = !! field.filterBy?.isPrimary; |
There was a problem hiding this comment.
No change here other than un-indentation from removing the switch.
oandregal
commented
Mar 21, 2024
| @@ -28,7 +23,7 @@ const Filters = memo( function Filters( { | |||
| const addFilterRef = useRef(); | |||
| const filters = []; | |||
| fields.forEach( ( field ) => { | |||
| if ( ! field.type ) { | |||
| if ( ! field.elements?.length ) { | |||
There was a problem hiding this comment.
This check was already in place, just after the type.
oandregal
force-pushed
the
remove/enumeration-type-dataviews
branch
from
52c2f1f to
b55e345
Compare
youknowriad
approved these changes
Mar 22, 2024
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Mar 27, 2024
Co-authored-by: oandregal <oandregal@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #55083
Related #55100
What?
Removes the
enumerationfield type.Why?
The
enumerationtype is too coarse for what we want to achieve with field types. We haven't ran into issues yet because we haven't implemented other features (editing).Two concrete examples were we could use a more fine-grained type system are:
type: enumerationfields are actually different things. For example, status is a string but author is a number.I plan to introduce other types soon to support other kind of filters as this one.
How?
Testing Instructions
Go to any of the dataviews-powered pages (Site Editor > Pages > Manage all pages, Site editor > Patterns, Site Editor > Patterns > Manage template parts, Site Editor > Templates) and verify filters still work as expected.