Cherry Pick PRs for (potential) final packages release for WP 6.5 #60157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
requested review from
youknowriad,
colorful-tones,
swissspidy,
fabiankaegy and
annezazu
getdave
added
[Type] Task
getdave
commented
Mar 25, 2024
Comment on lines
267
to
269
| <p className="description"> | ||
| { __( 'Scales the image with a lightbox effect' ) } | ||
| </p> |
There was a problem hiding this comment.
This code has been copied/moved and is not a new string.
getdave
commented
Mar 25, 2024
| </div> | ||
| <Button | ||
| icon={ linkOff } | ||
| label={ __( 'Disable expand on click' ) } |
There was a problem hiding this comment.
This code has been copied/moved and is not a new string.
This comment was marked as resolved.
This comment was marked as resolved.
swissspidy
reviewed
Mar 25, 2024
| const { type, overlayOpenedBy } = getContext(); | ||
| if ( | ||
| type === 'submenu' && | ||
| // Only open on hover if the overlay is closed. |
There was a problem hiding this comment.
This comment was missed:
Also a lack of braces here, which is usually error prone and might be against the coding standards too
There was a problem hiding this comment.
Good spot. It's frustrating that that code formatting issue wasn't picked up by linting. Going to raise a PR to fix this one.
There was a problem hiding this comment.
I was annoyed at the lack of braces too but I wanted to keep the same snippet that we have above for the other handler.
|
Size Change: +77 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
getdave
force-pushed
the
pick/packages-rc-final
branch
from
3d82db4 to
b9e73ef
Compare
|
Going to work on a new branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Contains PR cherry picked for a final (unconfirmed) packages release prior to WP 6.5.
Why?
The bugs identified were potentially severe enough to warannt a final release of packages to ensure the fixes can land in 6.5.
How?
Cherry Pick PRs
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast