date-fns: bump to v3.6 #60163
Merged
date-fns: bump to v3.6 #60163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Enhancement
|
Size Change: -1.71 kB (0%) Total Size: 1.72 MB
ℹ️ View Unchanged
|
tyxla
force-pushed
the
update/date-fns-3
branch
from
1822c8c to
e22ab39
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Mamaduka
approved these changes
Mar 28, 2024
There was a problem hiding this comment.
Thank you, @tyxla!
The update tests well for me ✅
Possible broken behavior on trunk
I noticed a strange behavior of the "Now" button. It resets the time to my machine's time instead of the timezone set by WP, which can lead to strange scheduling behavior.
Example:
- Open a draft post and switch the publishing date to the future.
- The save button changes the label to "Schedule."
- Switch the date back and the save button label will be restored to "Publish."
- Click on "Now" and repeat the same steps.
- Notice that the label isn't reverted to "Publish."
- Click "Now" again and the label is reverted, even though the time =< current time.
I'm not 100% sure what the intended behavior should be here, but initially, I thought it was a bug caused by the update and had to re-test it on the trunk.
Screencast
CleanShot.2024-03-28.at.12.35.54.mp4
Thanks for reporting @Mamaduka! I took a look and I'm able to reproduce on After a second look, it looks like this is intentional because of the 1-minute threshold we're adding to accommodate time differences between the server and the client, see #3036. cc @youknowriad if he has any thoughts, but I think we should leave this as-is to keep preventing the issue Riad described in the PR. |
|
@tyxla, even when I adjust minutes (remove 5min), I get the same result. I'll cover up my report on an issue and look into it separately. Thanks for the confirmation. |
|
Thanks @Mamaduka, this is definitely worth some additional attention since it might be misbehaving. Have you tried with disabling that threshold functionality manually, just to see if that resolves it for you? |
|
I've not, but I'll test it later. |
cbravobernal
pushed a commit
to garridinsi/gutenberg
that referenced
this pull request
Apr 9, 2024
* bump date-fns to v3.6 * bump use-lilius to 2.0.4 * CHANGELOG * Bump use-lilius to v2.0.5 Co-authored-by: tyxla <tyxla@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR bumps
date-fnsto the latestv3.6.0. Also bumpsuse-liliusto the latest version (v2.0.5) which also updateddate-fnsto v3.6.Why?
There are a bunch of fixes in it, plus some potential bundle size improvements.
How?
Just bumping some dependency versions of
date-fns.We're suggesting a bump to the latest version at Avarios/use-lilius#499. We might need to wait until that lands and a new version is released in order to ensure we don't use multipledate-fnsversions under the hood.use-lilius@v2.0.5was released withdate-fns@3.6.0as a dependency yesterday, so we're using that as well to match the underlyingdate-fnsdependency version.Testing Instructions
DateTimePicker,DatePickerandTimePickercomponents in Storybook still work well.Testing Instructions for Keyboard
None
Screenshots or screencast
None