Data views: Make trash a quick action again #60165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
requested review from
jameskoster,
richtabor,
jorgefilipecosta and
ntsekouras
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +52 B (0%) Total Size: 1.72 MB
ℹ️ View Unchanged
|
|
While you're at it, can you also fix this incorrect i18n code? For the second |
|
Let me know if I got that one right! |
|
It should be more like: |
|
It's not quite coming together for me with this:
Feel free to push directly to this branch if you prefer. |
swissspidy
reviewed
Mar 25, 2024
|
@jasmussen You're missing the third parameter to Consult the readme for how |
Co-authored-by: Pascal Birchler <pascalb@google.com>
|
Thanks, I've added this for now. It's giving me warnings in my editor, though:
A quick ping to @jorgefilipecosta as well — I was not involved in the original pieces here, so I've not been as close to this part of the codebase. |
swissspidy
reviewed
Mar 25, 2024
|
Simply forgot a comma, that's all. Like the error message says |
Co-authored-by: Pascal Birchler <pascalb@google.com>
ntsekouras
reviewed
Mar 26, 2024
ntsekouras
approved these changes
Mar 26, 2024
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Mar 27, 2024
* Data views: Make trash a quick action again * Use _n * Update packages/edit-site/src/components/actions/index.js Co-authored-by: Pascal Birchler <pascalb@google.com> * Update packages/edit-site/src/components/actions/index.js Co-authored-by: Pascal Birchler <pascalb@google.com> --------- Co-authored-by: Pascal Birchler <pascalb@google.com> Co-authored-by: Jorge Costa <jorge.costa@developer.pt>
cbravobernal
pushed a commit
to garridinsi/gutenberg
that referenced
this pull request
Apr 9, 2024
* Data views: Make trash a quick action again * Use _n * Update packages/edit-site/src/components/actions/index.js Co-authored-by: Pascal Birchler <pascalb@google.com> * Update packages/edit-site/src/components/actions/index.js Co-authored-by: Pascal Birchler <pascalb@google.com> --------- Co-authored-by: Pascal Birchler <pascalb@google.com> Co-authored-by: Jorge Costa <jorge.costa@developer.pt>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Followup to #59551. I misunderstood some of the changes in the PR, as far as what type of destructive actions were moved to the ellipsis menu. This moves the "trash" button back as a quick action.
Why?
Deleting pages are only partially destructive actions, insofar as they move a page or post to a trashcan vs. erasing them entirely. This is different from, say, reverting user customizations to a template, which is much harder to restore through revisions. This is the main nuance between delete and trash actions.
To that end, having quick actions for moving to trash also maintains parity with existing list views:
Anecdotally, I use the trash button there all the time.
I would even go as far as saying that there shouldn't be a modal confirm action when deleting a page. Perhaps we can keep it if the page is published, but if it's just a draft, it should just move it to trash, which is easily visible in the left navigation sidebar:
Removing this modal would also maintain parity with existing list views. But this would be something to consider exploring separately.
Testing Instructions