Global styles: output root padding CSS custom properties under the :root selector #60185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramonjd
added
[Type] Enhancement
|
Size Change: +2 B (0%) Total Size: 1.72 MB
ℹ️ View Unchanged
|
Moving the $use_root_padding logic from compute_style_properties to get_root_layout_rules. This entails: - deleting the --wp--root--padding-* entries from PROPERTIES_METADATA - in compute_style_properties, skipping padding properties for the root block if the theme has opted into using the root padding, and removing all other padding related logic - building the rules in get_root_layout_rules.
ramonjd
force-pushed
the
try/move-global-padding-to-root-selector
branch
from
d5ebad2
to
f81690a
Compare
ramonjd
commented
Mar 27, 2024
| } | ||
| } | ||
|
|
||
| if ( ROOT_BLOCK_SELECTOR === selector && useRootPadding ) { |
There was a problem hiding this comment.
I think I need to move padding CSS property generation back to where it was.
Consider
Here getLayoutStyles generates base layout styles - it's in edit-post package.
Without access to global styles in the post editor, getLayoutStyles cannot generate the root padding properties.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Follow up to:
For the frontend, moving the
$use_root_padding logicfromcompute_style_propertiestoget_root_layout_rules.This entails:
--wp--root--padding-*entries fromPROPERTIES_METADATAcompute_style_properties, skipping padding properties for the root block if the theme has opted into using the root padding, and removing all other padding related logicget_root_layout_rules.Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast