Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switching pattern categories inserter to Tabs component with arrow key navigation #60257

Merged
merged 24 commits into from
Apr 19, 2024
Merged

Switching pattern categories inserter to Tabs component with arrow key navigation #60257

merged 24 commits into from
Apr 19, 2024

Commits on Apr 16, 2024

  1. WIP for switching patterns to tab navigation

    @jeryj
    jeryj committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    32f21e7 View commit details
    Browse the repository at this point in the history

  2. remove unused code

    @jeryj
    jeryj committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    d9d8fd3 View commit details
    Browse the repository at this point in the history

  3. Let tabs component handle focus

    @jeryj
    jeryj committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    7b4fbf1 View commit details
    Browse the repository at this point in the history

  4. Pattern tab styles

    @jeryj
    jeryj committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    4e83e4b View commit details
    Browse the repository at this point in the history

  5. Fix overflow scrolling on tablist

    @jeryj
    jeryj committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    12f9f24 View commit details
    Browse the repository at this point in the history

  6. Select first tab on patterns open 

    I don't like this interaction because so much happens when you change the tab, but otherwise the first element of the tab panel isn't set when you initially move focus to the panel, so nothing is focused. It seems like there's a bug where you can't have a panel focused but not selected intially
    @jeryj
    jeryj committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    7acdeb9 View commit details
    Browse the repository at this point in the history

  7. Add placeholder to offset zoom-out mode space for tabpanel

    @jeryj
    jeryj committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    e8f8d9c View commit details
    Browse the repository at this point in the history

  8. Fix overflow on zoom out mode pattern inserter

    @jeryj
    jeryj committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    95951d2 View commit details
    Browse the repository at this point in the history

  9. Refactor making space for side panel by using :after

    @jeryj
    jeryj committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    96ebe8a View commit details
    Browse the repository at this point in the history

  10. Fix performance test

    @jeryj
    jeryj committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    74cd192 View commit details
    Browse the repository at this point in the history

  11. Fix useZoomOut mode hook to only run when showing and hiding the patt… 

    …erns panel
    @jeryj
    jeryj committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    1ec4685 View commit details
    Browse the repository at this point in the history

  12. More tweaks to zoom out mode hook to simplify

    @jeryj
    jeryj committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    494e72d View commit details
    Browse the repository at this point in the history

  13. Use tabs in controlled mode so there is no initial category set

    @jeryj
    jeryj committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    a405a75 View commit details
    Browse the repository at this point in the history

  14. Allow tab to be active but not selected 

    If defaultSelectedId is undefined, it will automatically set the first tab as selected.
    @jeryj
    jeryj committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    c2d2ecb View commit details
    Browse the repository at this point in the history

  15. Use selectedOnMount prop

    @jeryj
    jeryj committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    00c5c20 View commit details
    Browse the repository at this point in the history

  16. Revert "Allow tab to be active but not selected" 

    This reverts commit 4c6274f.
    @jeryj
    jeryj committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    1a44230 View commit details
    Browse the repository at this point in the history

  17. Revert "Use selectedOnMount prop" 

    This reverts commit eaef7d3.
    @jeryj
    jeryj committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    b7c495e View commit details
    Browse the repository at this point in the history

  18. Remove artifacts from local e2e performance test

    @jeryj
    jeryj committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    91fffab View commit details
    Browse the repository at this point in the history

  19. update tests to use the new tab role instead of button role

    @jeryj
    jeryj committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    c15acb2 View commit details
    Browse the repository at this point in the history

  20. Temporary workaround for performance test

    @jeryj
    jeryj committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    9918882 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2024

  1. Move some code back to its original location to make the review easier

    @jeryj
    jeryj committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    18d6355 View commit details
    Browse the repository at this point in the history

  2. Add missing __unstableSetEditorMode to useZoomOut useEffect dependency 

    Co-authored-by: Dave Smith <getdavemail@gmail.com>
    @jeryj @getdave
    jeryj and getdave authored Apr 18, 2024
    Configuration menu
    Copy the full SHA
    2119306 View commit details
    Browse the repository at this point in the history

  3. Update packages/block-editor/src/hooks/use-zoom-out.js 

    Co-authored-by: Dave Smith <getdavemail@gmail.com>
    @jeryj @getdave
    jeryj and getdave authored Apr 18, 2024
    Configuration menu
    Copy the full SHA
    bf2f485 View commit details
    Browse the repository at this point in the history

  4. Fix use-zoom-out hooks dependencies

    @jeryj
    jeryj committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    a873e04 View commit details
    Browse the repository at this point in the history