URL: return early in getFilename where url argument is falsy #60265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…'undefined' <string>` which could be interpreted by consumers as truthy
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ramonjd
added
[Type] Bug
ramonjd
changed the title
|
Size Change: +14 B (0%) Total Size: 1.72 MB
ℹ️ View Unchanged
|
ramonjd
commented
Mar 28, 2024
Expected: "file.jpg"
Received: "[%20A%20]"
andrewserong
approved these changes
Mar 28, 2024
ramonjd
added a commit
that referenced
this pull request
Mar 28, 2024
cbravobernal
pushed a commit
to garridinsi/gutenberg
that referenced
this pull request
Apr 9, 2024
…ss#60265) * Return early for falsy values so the URL constructor doesn't return `'undefined' <string>` which could be interpreted by consumers as truthy Co-authored-by: ramonjd <ramonopoly@git.wordpress.org> Co-authored-by: andrewserong <andrewserong@git.wordpress.org>
ramonjd
added a commit
that referenced
this pull request
Apr 12, 2024
ramonjd
added a commit
that referenced
this pull request
Apr 12, 2024
ramonjd
added a commit
that referenced
this pull request
Apr 14, 2024
ramonjd
added a commit
that referenced
this pull request
Apr 15, 2024
* Trying to change the header labels for background - Background > Background image - Using the title/url of the current image in the media uploader component * Simplify copy * We don't need this wild check now that #60265 is merged * Remove placeholder image icon and center text * Fix spacing Harmonize tools panels * the background size panel displays by default in the site editor for top-level styles, but only when there's an image available. Using constant for "image" * Update copy for unset image * Update border of button to match site logo upload button Co-authored-by: ramonjd <ramonopoly@git.wordpress.org> Co-authored-by: andrewserong <andrewserong@git.wordpress.org> Co-authored-by: noisysocks <noisysocks@git.wordpress.org> Co-authored-by: jameskoster <jameskoster@git.wordpress.org> Co-authored-by: richtabor <richtabor@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? How? Why? When?
getFilenameshould return early for falsy values so the URL constructor doesn't return'undefined' <string>which could be interpreted by consumers as truthy. Now.First seen: https://github.com/WordPress/gutenberg/pull/60264/files#r1542177474
Before
After
Testing Instructions
Fire up the editor and run in the browser console
Unit test it.
npm run test:unit packages/url/src/test/index.js