RichText: Switch from disableEditing to standard html readonly attribute #60327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glendaviesnz
requested review from
ellatrix,
fluiddot,
dcalhoun,
artemiomorales,
michalczaplinski and
ajitbohra
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
glendaviesnz
added
[Type] Code Quality
|
Size Change: +1.26 kB (0%) Total Size: 1.72 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 262fe03. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/8502126181
|
ellatrix
approved these changes
Apr 1, 2024
retrofox
reviewed
Apr 1, 2024
| @@ -111,7 +111,7 @@ export function RichTextWrapper( | |||
| __unstableDisableFormats: disableFormats, | |||
| disableLineBreaks, | |||
| __unstableAllowPrefixTransformations, | |||
| disableEditing, | |||
| readonly, | |||
There was a problem hiding this comment.
Should it be readOnly instead? O uppercase.
There was a problem hiding this comment.
retrofox
reviewed
Apr 1, 2024
| return ( | ||
| <PrivateRichText ref={ ref } { ...props } disableEditing={ false } /> | ||
| ); | ||
| return <PrivateRichText ref={ ref } { ...props } readonly={ false } />; |
There was a problem hiding this comment.
When do you think it could get public?
There was a problem hiding this comment.
@ellatrix what are your thoughts on this? It seems like a reasonably low-risk thing to add to the public API. Should we leave it private for a plugin release or two and aim to have it public for 6.6?
@retrofox I assume it is not much use to you until it is in a WP core release as many woo users won't be using the GB plugin, so no panic to have it public before 6.6?
There was a problem hiding this comment.
@glendaviesnz @retrofox Are you stil interested in making the readOnly attribute public? Does Woo have a use case for it?
It's been 8 months since it's been added, 6.6 and 6.7 releases passed by and now we're working on 6.8.
11 tasks
glendaviesnz
added
the
props-bot
github-actions
bot
removed
the
props-bot
cbravobernal
pushed a commit
to garridinsi/gutenberg
that referenced
this pull request
Apr 9, 2024
…ute (WordPress#60327) Co-authored-by: glendaviesnz <glendaviesnz@git.wordpress.org> Co-authored-by: ellatrix <ellatrix@git.wordpress.org> Co-authored-by: retrofox <retrofox@git.wordpress.org>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Implements suggestion here to switch to using a standard html attrib to flag RichText field as read only.
Why?
This is a more standard way of indicating this, and will make a better public API if we move this from private.
How?
Renames prop from
disableEditingtoreadonlyTesting Instructions