Remove block renaming control from advanced inspector controls group #60453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Type] Enhancement
talldan
requested review from
Mamaduka,
getdave,
SaxonF,
richtabor and
kevin940726
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
fabiankaegy
approved these changes
Apr 4, 2024
Thanks for being pragmatic. I think we can always reverse the decision if it turns out not quite right, or possibly try a different UI. |
|
Size Change: -55 B (0%) Total Size: 1.73 MB
ℹ️ View Unchanged
|
|
I'll need to update some tests by the looks of it, so I guess the 'how?' part suddenly got a bit more involved 😄 |
talldan
force-pushed
the
remove/block-name-control-from-advanced-tools
branch
from
e7d281f to
dec7d8a
Compare
cbravobernal
pushed a commit
to garridinsi/gutenberg
that referenced
this pull request
Apr 9, 2024
…ordPress#60453) * Remove block renaming control from advanced section * Remove block inspector renaming e2e test * Update e2e tests to use block options menu for block renaming * Use `clickBlockOptionsMenuItem` util
fabiankaegy
added a commit
that referenced
this pull request
May 29, 2024
This was referenced May 29, 2024
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes #60118
As proposed in that PR, removes the block renaming input from the advanced section of inspector controls.
How?
Highlight the code, press delete key
Testing Instructions
Screenshots or screencast
Before
After