Fix static posts page setting resolved template #60608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Feature] Templates API
ntsekouras
requested review from
Mamaduka,
youknowriad,
swissspidy and
carolinan
ntsekouras
commented
Apr 9, 2024
| const siteSettings = getSite(); | ||
| // First check if the current page is set as the posts page. | ||
| const isPostsPage = +postId === siteSettings?.page_for_posts; | ||
| if ( isPostsPage ) { |
There was a problem hiding this comment.
This is the main change. Rest of the changes are due to the added object deconstruction..
There was a problem hiding this comment.
The +postId is to make sure postId is an integer, in which cases it is not an integer could we not safely assume it is always an integer like we are assuming page_for_posts is an integer?
There was a problem hiding this comment.
I'm not really sure what is the flow that could result in a string and I left that untouched for now. ). Probably some cases for comparing post entities ids and the site settings - I think I had come across something like that in the past.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ntsekouras
commented
Apr 9, 2024
| const _homepageId = | ||
| siteData?.show_on_front === 'page' && | ||
| [ 'number', 'string' ].includes( typeof siteData.page_on_front ) && | ||
| !! +siteData.page_on_front // We also need to check if it's not zero(`0`). |
There was a problem hiding this comment.
This is the fix for the infinite loading in site editor.
|
Size Change: +528 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
jorgefilipecosta
approved these changes
Apr 11, 2024
| const siteSettings = getSite(); | ||
| // First check if the current page is set as the posts page. | ||
| const isPostsPage = +postId === siteSettings?.page_for_posts; | ||
| if ( isPostsPage ) { |
There was a problem hiding this comment.
The +postId is to make sure postId is an integer, in which cases it is not an integer could we not safely assume it is always an integer like we are assuming page_for_posts is an integer?
| !! +siteData.page_on_front // We also need to check if it's not zero(`0`). | ||
| ? siteData.page_on_front.toString() | ||
| : null; | ||
| const _postsPageId = |
There was a problem hiding this comment.
Shouldn't we also check page_for_posts for zero?
There was a problem hiding this comment.
It doesn't matter for page_for_posts because we don't use the value in a logical comparison(if block).
Mamaduka
approved these changes
Apr 11, 2024
creativecoder
pushed a commit
that referenced
this pull request
May 1, 2024
Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org> Co-authored-by: jorgefilipecosta <jorgefilipecosta@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
|
I just cherry-picked this PR to the update/fixes-for-wp-6-5-3 branch to get it included in the next release: f1abd8b |
creativecoder
removed
the
Backport to WP Minor Release
aaronjorbin
pushed a commit
that referenced
this pull request
May 2, 2024
Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org> Co-authored-by: jorgefilipecosta <jorgefilipecosta@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR aims to resolve: https://core.trac.wordpress.org/ticket/60836 (probably will need to create a GB issue..)
Additionally, this PR fixes a bug which causes 'infinite' loading in site editor when we have set a static
posts pageand no 'homepage`.Testing Instructions
posts pageand visit site editor. Observe that there is no 'infinite' loading.posts pageandhomepagesettings in reading settings.Tasks