Fix inserter pattern pagination focus loss #60620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @creative-reinilda. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
talldan
requested review from
glendaviesnz,
kevin940726,
t-hamano and
aaronrobertshaw
|
Size Change: +10 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
talldan
added
the
Backport to WP Minor Release
kevin940726
approved these changes
Apr 10, 2024
There are legitimate cases where an interactive control needs to be 'truly' disabled. |
t-hamano
approved these changes
Apr 10, 2024
There was a problem hiding this comment.
I tested it in the following environment.
- OS: Windows 11
- Browser: 124.0.2 (64-bit)
Test Result:
- trunk: Can reproduce the problem.
- This PR: Problem solved for both the Pattern Tab inserter, and the Pattern Modal.
I wonder if we should just make
__experimentalIsFocusablethe default whendisabledis true
This suggestion seems to be discussed on #56547.
|
I just cherry-picked this PR to the update/fixes-for-wp-6-5-3 branch to get it included in the next release: 9ad8c97 |
creativecoder
removed
the
Backport to WP Minor Release
aaronjorbin
pushed a commit
that referenced
this pull request
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #55043
Because the pagination buttons should remain focused when paginating, they should use
aria-disabledinstead ofdisabled.Why?
Applying
disabledto a focused button causes a focus loss. Because the inserter sidebar is implemented as a dialog, this results in the sidebar closing (though it's strange that it only happens in some browsers).How?
Adds the
__experimentalIsFocusableprop, which makes theButtoncomponent usearia-disabledinstead ofdisabled.Testing Instructions
Prerequisite: Use Safari (or firefox, where the issue has also been reported, though I personally couldn't reproduce)
In this PR: the inserter sidebar should stay open and focus should remain on the button
In trunk: Focus is lost and the sidebar closes
Screenshots or screencast
Before
Kapture.2024-04-10.at.12.32.01.mp4
After
Kapture.2024-04-10.at.12.29.16.mp4