Layout: Always add semantic classes #60668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +845 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
|
Tested and fixed the layout issue described above. My testing steps:
|
tellthemachines
approved these changes
Apr 12, 2024
andrewserong
added
the
Backport to WP Minor Release
andrewserong
approved these changes
Apr 12, 2024
|
I just spotted something weird in this PR branch: the Page List block is getting layout classnames when it shouldn't. Seems to be the only block without layout support to get the classnames. Trying to work out why now 😅 |
| layoutClasses.length > 0 ? layoutClasses : undefined | ||
| } | ||
| /> | ||
| ); |
There was a problem hiding this comment.
The problem seems to be that useLayoutClasses doesn't actually check if the block supports layout in order to output the classes (which is fine, that's not its role), so here, we're always passing in layout classes, whether the block supports layout or not. I think the check here should be blockSupportsLayout ? layoutClasses : undefined
There was a problem hiding this comment.
For posterity: the unwanted layout classes were appearing on Page List because it uses innerBlocksProps, where those classnames are retrieved from the block edit context and added to the inner blocks wrapper. So this would happen on any block with inner blocks and without layout support.
|
Could we please add an e2e test? 🙂 |
|
Hi, thanks for this PR, this fixes the issue for me ✅ Themes with |
|
@ellatrix, I can follow-up with e2e tests, but unfortunately not today :( |
|
Flaky tests detected in 36d8c2c. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/8660225514
|
|
I'm going to merge this and will follow-up with e2e tests ASAP. |
creativecoder
pushed a commit
that referenced
this pull request
May 2, 2024
* Layout: Always add semantic classes * Default to undefined * Feedback Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: tellthemachines <isabel_brison@git.wordpress.org> Co-authored-by: andrewserong <andrewserong@git.wordpress.org> Co-authored-by: colorful-tones <colorful-tones@git.wordpress.org> Co-authored-by: ellatrix <ellatrix@git.wordpress.org> Co-authored-by: davecpage <davecpage@git.wordpress.org>
creativecoder
removed
the
Backport to WP Minor Release
|
I manually cherry-picked this PR to the |
aaronjorbin
pushed a commit
that referenced
this pull request
May 2, 2024
* Layout: Always add semantic classes * Default to undefined * Feedback Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: tellthemachines <isabel_brison@git.wordpress.org> Co-authored-by: andrewserong <andrewserong@git.wordpress.org> Co-authored-by: colorful-tones <colorful-tones@git.wordpress.org> Co-authored-by: ellatrix <ellatrix@git.wordpress.org> Co-authored-by: davecpage <davecpage@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #60569.
PR fixes a missing semantic layout classes regression in the editor.
Why?
Matches behavior described in docs: https://developer.wordpress.org/block-editor/explanations/architecture/styles/#opting-out-of-generated-layout-styles.
Notes
useLayoutClassesis a privately exported hook used inReusableBlockEditandEditorCanvas.Testing Instructions
is-layout-constrained.Testing snippet
Testing Instructions for Keyboard
Same.
Screenshots or screencast